Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add acceleration structure overrides #1759

Merged
merged 30 commits into from
Oct 7, 2024
Merged

Add acceleration structure overrides #1759

merged 30 commits into from
Oct 7, 2024

Conversation

fabian-lunarg
Copy link
Contributor

@fabian-lunarg fabian-lunarg commented Sep 25, 2024 •
edited
Loading

  • Add code-overrides for vulkan's acceleration-structure API
  • Extend address-tracking to cover acceleration-structures
  • Start with device-address replacement for binding-tables and acceleration-structure buffers
  • Addition to capture device-address state-tracking
  • Add tracking for physical-device raytracing-properties
  • Leave TODOs

belongs to portable raytracing initiative

@fabian-lunarg
Add code-overrides around acceleration-structures
438a11f 
- required codegen adjustments
- only pass-through
@fabian-lunarg
Add struct-definition for AccelerationStructureInfoKHR
9c62a26 
- contains fields for capture/replay-time device-addresses
- populate those fields in OverrideGetAccelerationStructureDeviceAddressKHR
@fabian-lunarg
Add acceleration-structure support to BufferTracker
f629228 
- needs a better name now
@fabian-lunarg
Rename buffer_tracker -> device_address_tracker
7eddd19 
- Add hook to stop tracking on destroy
@fabian-lunarg
Implement address-remap in OverrideCmdBuildAccelerationStructuresKHR
e1be39e 
- use DeviceAddressTracker to rewrite addresses in-place
@fabian-lunarg
in-place sbt-address remap
d3122f4
@fabian-lunarg
Add device-address tracking in vulkan_state_writer
9d85b56
@fabian-lunarg
differentiate device-address/opaque-capture-address in capture
97001ea
@fabian-lunarg
Support VkBufferUsageFlags2CreateInfoKHR in OverrideCreateBuffer
193681e
@fabian-lunarg
cleanup, fuse two buffer-methods in state-writer
c13f927
@fabian-lunarg
Add code-overrides around acceleration-structures
5ea9c0e 
- required codegen adjustments
- only pass-through
@fabian-lunarg
Add struct-definition for AccelerationStructureInfoKHR
f262f40 
- contains fields for capture/replay-time device-addresses
- populate those fields in OverrideGetAccelerationStructureDeviceAddressKHR
@fabian-lunarg
Add acceleration-structure support to BufferTracker
b334358 
- needs a better name now
@fabian-lunarg
Rename buffer_tracker -> device_address_tracker
7ae8c0f 
- Add hook to stop tracking on destroy
@fabian-lunarg
Implement address-remap in OverrideCmdBuildAccelerationStructuresKHR
e4cce18 
- use DeviceAddressTracker to rewrite addresses in-place
@fabian-lunarg
in-place sbt-address remap
73c6ff1
@fabian-lunarg
Merge branch 'state_writer_tmp' into fabian_add_acceleration_structur…
4ed4a92 
…e_overrides
@fabian-lunarg
Merge remote-tracking branch 'upstream/dev' into fabian_add_accelerat…
aeeb5da 
…ion_structure_overrides
@fabian-lunarg
refactor/clean comments
37655f6
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 263907.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4895 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4895 passed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 263941.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4896 running.

@fabian-lunarg fabian-lunarg self-assigned this Sep 25, 2024
@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4896 passed.

@fabian-lunarg fabian-lunarg marked this pull request as ready for review September 25, 2024 12:11
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 265244.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4906 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4906 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 267593.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4925 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4925 passed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 267636.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 267654.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4929 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4929 passed.

MarkY-LunarG
MarkY-LunarG reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@MarkY-LunarG MarkY-LunarG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. I'm a little concerned that you're using core and extension entrypoints without checking to make sure they were enabled or that the version of Vulkan supports it (in several locations I pointed out). Please look those over.

framework/encode/vulkan_capture_manager.cpp Show resolved Hide resolved
framework/decode/vulkan_replay_consumer_base.cpp Show resolved Hide resolved
framework/encode/vulkan_state_writer.cpp Show resolved Hide resolved
framework/decode/vulkan_replay_consumer_base.cpp Outdated Show resolved Hide resolved
@fabian-lunarg
Merge remote-tracking branch 'upstream/dev' into fabian_add_accelerat…
66c06c2 
…ion_structure_overrides

- for good measure: merge upstream here after vulkan-header-update.
@fabian-lunarg
Add error for an unhandled switch-case
df82f37 
- not relevant now, but more cases might be added in the future
@fabian-lunarg
Clarify a workaround, leave related issue-#
638d3d1
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 268581.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4936 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4936 passed.

@fabian-lunarg
correct trimming for vkGetBufferDeviceAddress(KHR)
0daf9ee 
- remove override on replay-side
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 268639.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4937 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4937 passed.

@fabian-lunarg fabian-lunarg merged commit 3b7960c into LunarG:dev Oct 7, 2024
8 checks passed
@fabian-lunarg fabian-lunarg deleted the fabian_add_acceleration_structure_overrides branch October 7, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkY-LunarG MarkY-LunarG MarkY-LunarG approved these changes

Assignees

@fabian-lunarg fabian-lunarg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabian-lunarg @ci-tester-lunarg @MarkY-LunarG