Fix warnings #1741
Merged
Fix warnings #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor changes to reduce warnings seen when using gfxreconstruct, no (intentional) functional changes. Using struct as in the definition for forward declaration of the ReplayDeviceInfo tag (clang -Wmismatched-tags) Explicitely define assignment operators for clang -Wdeprecated-copy-with-user-provided-copy warning. clang output: > definition of implicit copy assignment operator for 'ShaderDescriptorInfo' > is deprecated because it has a user-provided copy constructor
|
Author dfriederich not on autobuild list. Waiting for curator authorization before starting CI build. |
|
minor change, mostly to avoid getting warnings when using gfxreconstruct in a project as dependency with enabled warnings. |
|
Author dfriederich not on autobuild list. Waiting for curator authorization before starting CI build. |
|
@bradgrantham-lunarg thanks for the format fix :-) |
|
CI gfxreconstruct build queued with queue ID 255991. |
|
CI gfxreconstruct build # 4827 running. |
|
CI gfxreconstruct build # 4827 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to reduce warnings seen when using gfxreconstruct, no (intentional) functional changes.
Using struct as in the definition for forward declaration of the ReplayDeviceInfo tag (clang -Wmismatched-tags)
Explicitly define assignment operators for clang
-Wdeprecated-copy-with-user-provided-copy warning.
clang output: