-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose 2 symbols from android_main #1739
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7cb928b
Expose 2 symbols from android_main
panos-lunarg 8a80c41
Limit usage of device table in vulkan replay consumer
panos-lunarg 3f96a18
Introducing SetInjectedCommandCallbacks().
panos-lunarg ed163cb
Add export-dynamic in gfxrecon-replay
panos-lunarg 4227ac6
Declare type for SetInjectedCommandCallbacks
panos-lunarg de69401
Replace -export-dynamic with -rdynamic
panos-lunarg 4aaa6ff
Fix clang-format
panos-lunarg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
/* | ||
** Copyright (c) 2024 Valve Corporation | ||
** Copyright (c) 2024 LunarG, Inc. | ||
** | ||
** Permission is hereby granted, free of charge, to any person obtaining a | ||
** copy of this software and associated documentation files (the "Software"), | ||
** to deal in the Software without restriction, including without limitation | ||
** the rights to use, copy, modify, merge, publish, distribute, sublicense, | ||
** and/or sell copies of the Software, and to permit persons to whom the | ||
** Software is furnished to do so, subject to the following conditions: | ||
** | ||
** The above copyright notice and this permission notice shall be included in | ||
** all copies or substantial portions of the Software. | ||
** | ||
** THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
** IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
** FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
** AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
** LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING | ||
** FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER | ||
** DEALINGS IN THE SOFTWARE. | ||
*/ | ||
|
||
#include "util/defines.h" | ||
#include "util/logging.h" | ||
#include "mark_injected_commands.h" | ||
|
||
GFXRECON_BEGIN_NAMESPACE(gfxrecon) | ||
GFXRECON_BEGIN_NAMESPACE(decode) | ||
|
||
static void BeginEndInjectedCommandsNoop(void* data) | ||
{ | ||
GFXRECON_UNREFERENCED_PARAMETER(data); | ||
} | ||
|
||
#ifdef GFXRECON_DEBUG_BUILD | ||
static bool injecting_api_calls_g = false; | ||
#endif | ||
|
||
static PFN_BeginInjectedCommands BeginInjectCommands_fp = BeginEndInjectedCommandsNoop; | ||
static PFN_EndInjectedCommands EndInjectCommands_fp = BeginEndInjectedCommandsNoop; | ||
static void* InjectCommandsData_ptr = nullptr; | ||
|
||
extern "C" void | ||
SetInjectedCommandCallbacks(PFN_BeginInjectedCommands begin_fp, PFN_EndInjectedCommands end_fp, void* data) | ||
{ | ||
BeginInjectCommands_fp = begin_fp != nullptr ? begin_fp : BeginEndInjectedCommandsNoop; | ||
EndInjectCommands_fp = end_fp != nullptr ? end_fp : BeginEndInjectedCommandsNoop; | ||
InjectCommandsData_ptr = data; | ||
} | ||
|
||
void BeginInjectedCommands() | ||
{ | ||
#ifdef GFXRECON_DEBUG_BUILD | ||
// Nested BeginInjectedCommands/EndInjectedCommands | ||
GFXRECON_ASSERT(!injecting_api_calls_g); | ||
injecting_api_calls_g = true; | ||
#endif | ||
|
||
BeginInjectCommands_fp(InjectCommandsData_ptr); | ||
} | ||
|
||
void EndInjectedCommands() | ||
{ | ||
#ifdef GFXRECON_DEBUG_BUILD | ||
// Nested BeginInjectedCommands/EndInjectedCommands | ||
GFXRECON_ASSERT(injecting_api_calls_g); | ||
injecting_api_calls_g = false; | ||
#endif | ||
|
||
EndInjectCommands_fp(InjectCommandsData_ptr); | ||
} | ||
|
||
GFXRECON_END_NAMESPACE(decode) | ||
GFXRECON_END_NAMESPACE(gfxrecon) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
/* | ||
** Copyright (c) 2024 Valve Corporation | ||
** Copyright (c) 2024 LunarG, Inc. | ||
** | ||
** Permission is hereby granted, free of charge, to any person obtaining a | ||
** copy of this software and associated documentation files (the "Software"), | ||
** to deal in the Software without restriction, including without limitation | ||
** the rights to use, copy, modify, merge, publish, distribute, sublicense, | ||
** and/or sell copies of the Software, and to permit persons to whom the | ||
** Software is furnished to do so, subject to the following conditions: | ||
** | ||
** The above copyright notice and this permission notice shall be included in | ||
** all copies or substantial portions of the Software. | ||
** | ||
** THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
** IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
** FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
** AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
** LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING | ||
** FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER | ||
** DEALINGS IN THE SOFTWARE. | ||
*/ | ||
|
||
#include "util/defines.h" | ||
|
||
GFXRECON_BEGIN_NAMESPACE(gfxrecon) | ||
GFXRECON_BEGIN_NAMESPACE(decode) | ||
|
||
using PFN_BeginInjectedCommands = void (*)(void*); | ||
using PFN_EndInjectedCommands = void (*)(void*); | ||
using PFN_SetInjectedCommandCallbacks = void (*)(PFN_BeginInjectedCommands, PFN_EndInjectedCommands, void*); | ||
|
||
// Interface for registering callbacks so that GFXReconstruct can notify an external library about | ||
// generated API calls that are not included in the capture file. | ||
// Intended usage: GFXR will call PFN_BeginInjectedCommands once before it starts issuing synthesized | ||
// API calls, and PFN_EndInjectedCommands once it is finished. | ||
// A void * pointer allows passing optional data that will be forwared into both callbacks. | ||
// | ||
// SetInjectedCommandCallbacks can be discovered through dlsym/GetProcAddress. | ||
extern "C" void | ||
SetInjectedCommandCallbacks(PFN_BeginInjectedCommands begin_fp, PFN_EndInjectedCommands end_fp, void* data); | ||
|
||
void BeginInjectedCommands(); | ||
|
||
void EndInjectedCommands(); | ||
|
||
GFXRECON_END_NAMESPACE(decode) | ||
GFXRECON_END_NAMESPACE(gfxrecon) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, I wonder if we should have some header/place where all exported api's are declared with some docu.
Right now the exported functions are defined in different cpp files, and if I don't know what to look out for I would not find any connection. (well maybe there is no connection :-) ).