Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse asset file #1729

Draft
wants to merge 99 commits into
base: dev
Choose a base branch
from
Draft

Reuse asset file #1729

wants to merge 99 commits into from

Commits on Sep 8, 2024

  1. Distinguish between muttable and immutable descriptors 

    Fine grain descriptor set encode wrapper so that it can distinguish
between mutable (storage) and immutable (uniform) images and buffers.
    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    ec46a9b View commit details
    Browse the repository at this point in the history

  2. Track descriptors and transfer commands that affect assets

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    6cea230 View commit details
    Browse the repository at this point in the history

  3. State writer checks for dirty flag before dumping and prints statistics

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    66700a3 View commit details
    Browse the repository at this point in the history

  4. Move asset tracking in command buffer

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    cae0083 View commit details
    Browse the repository at this point in the history

  5. Print exec time of WriteResourceMemoryState

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    7a280d2 View commit details
    Browse the repository at this point in the history

  6. Track non swapchain images attachments with stope_op_store

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    e9c9c3b View commit details
    Browse the repository at this point in the history

  7. A fix in TrackMappedAssetsWrites

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    237082f View commit details
    Browse the repository at this point in the history

  8. Print runtime of whole WriteState()

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    58c88b5 View commit details
    Browse the repository at this point in the history

  9. Write and read new metacomands

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    8b172cb View commit details
    Browse the repository at this point in the history

  10. Add a file stack in file processor

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    a3caba2 View commit details
    Browse the repository at this point in the history

  11. ExecuteBlocksFromFile meta command

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    f989f67 View commit details
    Browse the repository at this point in the history

  12. Abstract out composition of kExecuteBlocksFromFile in state writer

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    825e7db View commit details
    Browse the repository at this point in the history

  13. FileProcessor: Use correct number of blocks

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    bec0074 View commit details
    Browse the repository at this point in the history

  14. Store descriptor state in asset file

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    f675d22 View commit details
    Browse the repository at this point in the history

  15. Convert now should understand ExecuteBlocksFromFile metacommand

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    4afce37 View commit details
    Browse the repository at this point in the history

  16. Writing a header in the asset file, makes it legible to convert

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    b6493dd View commit details
    Browse the repository at this point in the history

  17. Rename referenced_assets variable

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    8c633ba View commit details
    Browse the repository at this point in the history

  18. TrackMappedAssetsWrites should be working correctly now

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    597c06d View commit details
    Browse the repository at this point in the history

  19. Create asset file at the right moment

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    5b1366f View commit details
    Browse the repository at this point in the history

  20. Group similar functions together

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    bff7f4a View commit details
    Browse the repository at this point in the history

  21. Unify tracked images and buffers

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    12bdb82 View commit details
    Browse the repository at this point in the history

  22. Ability to override path to asset path during replay

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    9b3a06a View commit details
    Browse the repository at this point in the history

  23. Rename file processor variables

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    dc5612d View commit details
    Browse the repository at this point in the history

  24. Guard assets map with a mutex

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    69acf80 View commit details
    Browse the repository at this point in the history

  25. Fix for asset-file-path replay argument

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    1203210 View commit details
    Browse the repository at this point in the history

  26. Asset file generation is optional and off by default 

    Asset file generetaion is controlled by an environment variable
    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    064c873 View commit details
    Browse the repository at this point in the history

  27. Added some documentation

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    61f369c View commit details
    Browse the repository at this point in the history

  28. Several transfero commands were omitted by mistake

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    41aca5a View commit details
    Browse the repository at this point in the history

  29. Add mesh/task shader draw calls

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    b6618d7 View commit details
    Browse the repository at this point in the history

  30. Code formatting

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    e229c2f View commit details
    Browse the repository at this point in the history

  31. Fix windows and android builds

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    b15626a View commit details
    Browse the repository at this point in the history

  32. Some clean ups

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    5a164ca View commit details
    Browse the repository at this point in the history

  33. Fix 32bit build

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    6b727dc View commit details
    Browse the repository at this point in the history

  34. Expose WriteAssetsGFXR through the layer

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    d3f8775 View commit details
    Browse the repository at this point in the history

  35. Dump assets is also controled by an android setting 

    Android setting capture_android_dump_assets can trigger an asset dump in
the asset file.
    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    9ecd5d9 View commit details
    Browse the repository at this point in the history

  36. Fix formatting

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    9d61e61 View commit details
    Browse the repository at this point in the history

  37. Fix windows build

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    1347c03 View commit details
    Browse the repository at this point in the history

  38. Fix formatting

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    7dd6184 View commit details
    Browse the repository at this point in the history

  39. Track secondary command buffers

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    d3d889f View commit details
    Browse the repository at this point in the history

  40. Fix bug in SetDescriptorUpdateTemplateInfo

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    b54bdd4 View commit details
    Browse the repository at this point in the history

  41. There should be 3 encoded values

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    120cac6 View commit details
    Browse the repository at this point in the history

  42. Rename a function

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    382df46 View commit details
    Browse the repository at this point in the history

  43. No need to clear map

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    e3ca6ab View commit details
    Browse the repository at this point in the history

  44. Track dynamic rendering

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    16f8681 View commit details
    Browse the repository at this point in the history

  45. Handle VK_DESCRIPTOR_TYPE_MUTABLE_VALVE

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    e4967e6 View commit details
    Browse the repository at this point in the history

  46. These are Post functions, not Pre

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    306cb51 View commit details
    Browse the repository at this point in the history

  47. Reverted DescriptorUpdateTemplate

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    a70a0a5 View commit details
    Browse the repository at this point in the history

  48. Fix windows build

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    f8ebd58 View commit details
    Browse the repository at this point in the history

  49. Fix in TrackBeginRendering

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    d9e597d View commit details
    Browse the repository at this point in the history

  50. CmdBindDescriptorSets can bind VK_NULL_HANDLE desc set handles

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    dc86e8e View commit details
    Browse the repository at this point in the history

  51. GetTrackedMemoryRegions should lock the mutex

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    ef45a13 View commit details
    Browse the repository at this point in the history

  52. Fix a couple of typos

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    5eda5e7 View commit details
    Browse the repository at this point in the history

  53. Scan only dirty regions

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    1572b15 View commit details
    Browse the repository at this point in the history

  54. Write state file for each frame

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    b04347d View commit details
    Browse the repository at this point in the history

  55. Deactivate state file status when done with trim ranges

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    e0070a3 View commit details
    Browse the repository at this point in the history

  56. Enable state file loading for android

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    4e40c45 View commit details
    Browse the repository at this point in the history

  57. Override path

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    0abbfc8 View commit details
    Browse the repository at this point in the history

  58. Removed couple of stray printfs

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    6dd2681 View commit details
    Browse the repository at this point in the history

  59. Writing state files is control by an env var

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    9c2c86b View commit details
    Browse the repository at this point in the history

  60. --override-path now works for gfxrecon-convert too

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    dc1547e View commit details
    Browse the repository at this point in the history

  61. Fixes for other file processor users

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    5aeb8aa View commit details
    Browse the repository at this point in the history

  62. Add few comments in ExecuteBlocksFromFile metacommand

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    0dc5578 View commit details
    Browse the repository at this point in the history

  63. Specifying state file for replay is enough

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    d820d67 View commit details
    Browse the repository at this point in the history

  64. Fix override-path for convert

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    3fb6efb View commit details
    Browse the repository at this point in the history

  65. Track resource <-> descriptor set connections 

    When a resource that is bound to one or more descriptor sets is deleted
then those descriptor sets are marked as dirty. This will make them to
be dumped again in the next WriteState
    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    5a790c0 View commit details
    Browse the repository at this point in the history

  66. Small cleanup in CommonCaptureManager

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    2262c34 View commit details
    Browse the repository at this point in the history

  67. Correct some mess ups after rebasing with dev

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    bc1db1d View commit details
    Browse the repository at this point in the history

  68. Typo fix

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    f34065a View commit details
    Browse the repository at this point in the history

  69. Changed incosistent function name

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    3319b30 View commit details
    Browse the repository at this point in the history

  70. Missing error check in file processor

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    aa09680 View commit details
    Browse the repository at this point in the history

  71. An attempt to standarize block indices

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    ded80f1 View commit details
    Browse the repository at this point in the history

  72. Got rid of --override-path

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    9bb958e View commit details
    Browse the repository at this point in the history

  73. Handles are pointers. Print hex values

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    329a5cb View commit details
    Browse the repository at this point in the history

  74. Hush some warnings when we know it's ok

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    71903fb View commit details
    Browse the repository at this point in the history

  75. Removed forgotten references to asset and override path

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    6ce6882 View commit details
    Browse the repository at this point in the history

  76. Detect self referencing ExecuteBlocksFromFile commands

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    b172897 View commit details
    Browse the repository at this point in the history

  77. Minor var renames and optimization

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    fc2fe1f View commit details
    Browse the repository at this point in the history

  78. Copy paste mistake enabled state files along with asset

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    d8cc332 View commit details
    Browse the repository at this point in the history

  79. Asset files type changed to .gfxa

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    ad4a2c6 View commit details
    Browse the repository at this point in the history

  80. Convert now recognizes asset files

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    2b13f13 View commit details
    Browse the repository at this point in the history

  81. Frame number is now written in asset file

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    92e1804 View commit details
    Browse the repository at this point in the history

  82. Asset file consumer

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    0bb3291 View commit details
    Browse the repository at this point in the history

  83. Keep asset file information per frame

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    b073091 View commit details
    Browse the repository at this point in the history

  84. Asset consumer tracks greatest detect id

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    dcfce01 View commit details
    Browse the repository at this point in the history

  85. Something is starting to work

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    0a79e38 View commit details
    Browse the repository at this point in the history

  86. Utilize graphics::vulkan_struct_get_pnext

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    fe69ffb View commit details
    Browse the repository at this point in the history

  87. Fixes in the replay consumer generator

    @panos-lunarg
    panos-lunarg committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    89533b2 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Things seem to work

    @panos-lunarg
    panos-lunarg committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    5193a55 View commit details
    Browse the repository at this point in the history

  2. init_from_asset_file flag hack

    @panos-lunarg
    panos-lunarg committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    4d6bd1c View commit details
    Browse the repository at this point in the history

  3. Remove more instrumentation

    @panos-lunarg
    panos-lunarg committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    5c70695 View commit details
    Browse the repository at this point in the history

  4. Add framework/encode/custom_exported_layer_funcs.h

    @panos-lunarg
    panos-lunarg committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    2674af4 View commit details
    Browse the repository at this point in the history

  5. Fix win build

    @panos-lunarg
    panos-lunarg committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    640b192 View commit details
    Browse the repository at this point in the history

  6. Fix tests

    @panos-lunarg
    panos-lunarg committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    d93fd22 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Correct frame counting

    @panos-lunarg
    panos-lunarg committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    5104c7b View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Drop GIPA in favor of VkLayerSettingsCreateInfoEXT

    @panos-lunarg
    panos-lunarg committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    9cd2a06 View commit details
    Browse the repository at this point in the history

  2. Remove init_from_asset_file and clang-format

    @panos-lunarg
    panos-lunarg committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    2ec3894 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Notify capture laye about frame state begin/end markers

    @panos-lunarg
    panos-lunarg committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    045909d View commit details
    Browse the repository at this point in the history

  2. Fix windows build

    @panos-lunarg
    panos-lunarg committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    813bcf8 View commit details
    Browse the repository at this point in the history

  3. clang-format

    @panos-lunarg
    panos-lunarg committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    46ede91 View commit details
    Browse the repository at this point in the history