Make IDXGISwapChain buffer cast conditional #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At replay, the buffer returned by IDXGISwapChain::GetBuffer was always cast to an ID3D12Resource type, which can lead to a crash when the caller requests a different type. With this change, the returned buffer is only processed as an ID3D12Resource type when the caller specifically requests an ID3D12Resource type.
|
CI gfxreconstruct build queued with queue ID 251300. |
|
CI gfxreconstruct build # 4794 running. |
|
CI gfxreconstruct build # 4794 passed. |
bradgrantham-lunarg
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At replay, the buffer returned by IDXGISwapChain::GetBuffer was always cast to an ID3D12Resource type, which can lead to a crash when the caller requests a different type.
With this change, the returned buffer is only processed as an ID3D12Resource type when the caller specifically requested an ID3D12Resource type.