Fix D3D12 WriteToSubresource size calculation #1699
Conversation
|
CI gfxreconstruct build queued with queue ID 246515. |
| case D3D12_RESOURCE_DIMENSION_TEXTURE1D: | ||
| data_size = GetOneRowSizeByDXGIFormat( |
There was a problem hiding this comment.
The GetOneRowSizeByDXGIFromat functions are no longer used. Would you like me to remove them as part of this change?
There was a problem hiding this comment.
No, that can be a separate PR. Thanks!
| return size; | ||
| } | ||
|
|
||
| uint64_t GetPixelByteSize(DXGI_FORMAT format) |
There was a problem hiding this comment.
The existing GetSubresourcePixelByteSize function was specifically documented as not supporting compressed texture formats, so I added a separate function to retrieve the block size for BC formats and then added this function to combine them. These could all be merged into a single function if you don't think that would produce any unexpected side effects.
There was a problem hiding this comment.
I think these are fine separated.
|
CI gfxreconstruct build # 4735 running. |
|
CI gfxreconstruct build # 4735 passed. |
The current WriteToSubresource size calculation may not work correctly when either the DstSubresource parameter is greater than 0 or the subresource is a texture with a block compressed format. The size calculation was updated to handle these cases using texture utility code that was originally added for D3D11, where it is used for the D3D11 UpdateSubresource and WriteToSubresource size calculations.
dgraves
force-pushed
the
fix-d3d12-writetosubresource-size-calc
branch
from
2d58500
to
795569c
Compare
|
CI gfxreconstruct build queued with queue ID 250573. |
|
CI gfxreconstruct build # 4784 running. |
|
CI gfxreconstruct build # 4784 passed. |
The current WriteToSubresource size calculation may not work correctly when either the DstSubresource parameter is greater than 0 or the subresource is a texture with a block compressed format.
The size calculation was updated to handle these cases using texture utility code that was originally added for D3D11, where it is used for the D3D11 UpdateSubresource and WriteToSubresource size calculations.
This fixes some crashes in ID3D12Resource::WriteToSubresource observed when capturing on devices with integrated GPUs.