remove CONVERT_EXPERIMENTAL_D3D12 and always support D3D12 in convert #1691
Conversation
|
CI gfxreconstruct build queued with queue ID 245247. |
bradgrantham-lunarg
requested review from
nickdriscoll-lunarg and
davidd-lunarg
|
CI gfxreconstruct build # 4712 running. |
|
CI gfxreconstruct build # 4712 failed. |
|
CI gfxreconstruct build queued with queue ID 245333. |
|
CI gfxreconstruct build # 4714 running. |
|
CI gfxreconstruct build queued with queue ID 245348. |
|
CI gfxreconstruct build queued with queue ID 245350. |
|
CI gfxreconstruct build # 4716 running. |
|
CI gfxreconstruct build # 4716 passed. |
tools/convert/main.cpp
Outdated
| GFXRECON_LOG_INFO( | ||
| "Capture file contains D3D12 content but gfxrecon-convert is not compiled with D3D12 support."); |
There was a problem hiding this comment.
It looks like DetectAPI can only return detected_d3d12 == true if D3D12_SUPPORT is defined so it may not be possible to hit this warning.
There was a problem hiding this comment.
Good point, let me consider what can be done for those lines of code if anything.
There was a problem hiding this comment.
I inverted the sense and instead log a message if no Vulkan content was found.
I think this is a stopgap; we may find ourselves shortly with a combination of possible API support compiled into convert. Maybe we could make a generic detection decoder that would populate a std::set of ApiFamilyId and then wouldn't need specific API support compiled into decoders or consumers.
bradgrantham-lunarg
force-pushed
the
brad-promote-d3d12-convert-to-default
branch
from
1fbde9a
to
ddeece6
Compare
|
CI gfxreconstruct build queued with queue ID 245830. |
|
CI gfxreconstruct build # 4721 running. |
|
CI gfxreconstruct build queued with queue ID 245851. |
|
CI gfxreconstruct build # 4722 running. |
|
CI gfxreconstruct build # 4722 passed. |
No description provided.