Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force_fifo_present_mode optional setting #1687

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

zongdu-arm
Copy link
Contributor

If presentMode is forced to VK_PRESENT_MODE_FIFO_KHR in vkCreateSwapchainKHR, the application will crash if it does not use VK_PRESENT_MODE_FIFO_KHR presentMode when capturing.

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2024

CLA assistant check
All committers have signed the CLA.

@ci-tester-lunarg
Copy link

Author zongdu-arm not on autobuild list. Waiting for curator authorization before starting CI build.

@zongdu-arm zongdu-arm marked this pull request as draft August 28, 2024 02:41
@zongdu-arm zongdu-arm marked this pull request as ready for review August 28, 2024 02:41
@fabian-lunarg
Copy link
Contributor

Ubuntu GCC Release failed due to clang-format issues in framework/encode/capture_manager.h @zongdu-arm

@ci-tester-lunarg
Copy link

Author zongdu-arm not on autobuild list. Waiting for curator authorization before starting CI build.

@zongdu-arm
Copy link
Contributor Author

Hi @fabian-lunarg ,
I have fixed the code check error, please approval to CI test again.

@fabian-lunarg
Copy link
Contributor

Hi @fabian-lunarg , I have fixed the code check error, please approval to CI test again.

"Author zongdu-arm not on autobuild list"
let me find out what we can do to un-block CI for your PRs, will come back

@fabian-lunarg fabian-lunarg linked an issue Aug 29, 2024 that may be closed by this pull request
USAGE_android.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MarkY-LunarG MarkY-LunarG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small nit to fix from my standpoint.

@bradgrantham-lunarg
Copy link
Contributor

This sounds like a good PR. Because it changes the default capture behavior and some developers may have depended on the behavior (maybe without knowing it), we would like a little time to let this soak and discuss it with a couple of high-priority developers. We anticipate this going in late next week if no one has any objections.

If presentMode is forced to VK_PRESENT_MODE_FIFO_KHR in vkCreateSwapchainKHR, the application will crash if it does not use VK_PRESENT_MODE_FIFO_KHR presentMode when capturing.
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 245993.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4726 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4726 passed.

@MarkY-LunarG
Copy link
Contributor

This sounds like a good PR. Because it changes the default capture behavior and some developers may have depended on the behavior (maybe without knowing it), we would like a little time to let this soak and discuss it with a couple of high-priority developers. We anticipate this going in late next week if no one has any objections.

Clarification, Brad did a quick once over and had not realized that the behavior is already there and done by default, but this option is actually allowing the default behavior to be changed for anyone who wants to modify it with this new setting. Because of that, I believe we're good to go.

@bradgrantham-lunarg
Copy link
Contributor

Just a moment - I realize that since this has changed recently I need to review again

@fabian-lunarg fabian-lunarg merged commit fa95511 into LunarG:dev Sep 16, 2024
8 checks passed
@zongdu-arm zongdu-arm deleted the force_fifo_present_mode branch September 20, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[capture] Added force_fifo_present_mode optional setting
6 participants