-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add force_fifo_present_mode optional setting #1687
Conversation
Author zongdu-arm not on autobuild list. Waiting for curator authorization before starting CI build. |
Ubuntu GCC Release failed due to clang-format issues in |
d1365e4
to
305b868
Compare
Author zongdu-arm not on autobuild list. Waiting for curator authorization before starting CI build. |
Hi @fabian-lunarg , |
"Author zongdu-arm not on autobuild list" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small nit to fix from my standpoint.
This sounds like a good PR. Because it changes the default capture behavior and some developers may have depended on the behavior (maybe without knowing it), we would like a little time to let this soak and discuss it with a couple of high-priority developers. We anticipate this going in late next week if no one has any objections. |
If presentMode is forced to VK_PRESENT_MODE_FIFO_KHR in vkCreateSwapchainKHR, the application will crash if it does not use VK_PRESENT_MODE_FIFO_KHR presentMode when capturing.
305b868
to
e16cfaa
Compare
CI gfxreconstruct build queued with queue ID 245993. |
CI gfxreconstruct build # 4726 running. |
CI gfxreconstruct build # 4726 passed. |
Clarification, Brad did a quick once over and had not realized that the behavior is already there and done by default, but this option is actually allowing the default behavior to be changed for anyone who wants to modify it with this new setting. Because of that, I believe we're good to go. |
Just a moment - I realize that since this has changed recently I need to review again |
If presentMode is forced to VK_PRESENT_MODE_FIFO_KHR in vkCreateSwapchainKHR, the application will crash if it does not use VK_PRESENT_MODE_FIFO_KHR presentMode when capturing.