-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dump all subresources of render target images #1681
Dump all subresources of render target images #1681
Conversation
CI gfxreconstruct build queued with queue ID 240482. |
CI gfxreconstruct build # 4642 running. |
CI gfxreconstruct build # 4642 passed. |
8c8650d
to
3684d42
Compare
CI gfxreconstruct build queued with queue ID 241532. |
CI gfxreconstruct build # 4668 running. |
3684d42
to
97a4346
Compare
CI gfxreconstruct build queued with queue ID 241633. |
CI gfxreconstruct build # 4670 running. |
CI gfxreconstruct build # 4670 passed. |
97a4346
to
41d8727
Compare
CI gfxreconstruct build queued with queue ID 245004. |
CI gfxreconstruct build # 4710 running. |
CI gfxreconstruct build # 4710 passed. |
Changes look good. I ran the two CI dump resources tests I have handy on the CI systems against this branch and got good results. I had to merge this branch on top of the latest dev branch in order to get some of the tests to run. (The dev branch has a fix to avoid seg faults when running one of my CI tests.) Some of the dump resource output file names changed, so file comparisons failed (but the images in the files look good), but the archived file names can be changed once this PR is merged to dev. (That's a caution against changing output dump resources file names, it will break CI in the future.) |
41d8727
to
ee5f4c2
Compare
CI gfxreconstruct build queued with queue ID 255348. |
CI gfxreconstruct build # 4821 running. |
ee5f4c2
to
5e820df
Compare
CI gfxreconstruct build queued with queue ID 255362. |
CI gfxreconstruct build # 4822 running. |
CI gfxreconstruct build # 4822 passed. |
CI gfxreconstruct build queued with queue ID 257879. |
CI gfxreconstruct build # 4842 running. |
CI gfxreconstruct build # 4842 passed. |
CI gfxreconstruct build queued with queue ID 258639. |
CI gfxreconstruct build # 4849 running. |
CI gfxreconstruct build # 4849 failed. |
CI gfxreconstruct build queued with queue ID 259015. |
CI gfxreconstruct build # 4858 running. |
CI gfxreconstruct build # 4858 passed. |
I ran the dump resources CI tests. (Manually, since the changes to CI infrastructure are not yet in the CI master branch.) There was a single failure, caused by the output file name change. Changes look good. We can rename the archive file name when dump resources is added to CI. |
No description provided.