Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump all subresources of render target images #1681

Conversation

panos-lunarg
Copy link
Contributor

No description provided.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 240482.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4642 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4642 passed.

@panos-lunarg panos-lunarg marked this pull request as draft August 22, 2024 12:10
@panos-lunarg panos-lunarg force-pushed the vulkan_dump_resources_dump_rt_subresources branch from 8c8650d to 3684d42 Compare August 23, 2024 14:12
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 241532.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4668 running.

@panos-lunarg panos-lunarg force-pushed the vulkan_dump_resources_dump_rt_subresources branch from 3684d42 to 97a4346 Compare August 23, 2024 14:53
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 241633.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4670 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4670 passed.

@panos-lunarg panos-lunarg force-pushed the vulkan_dump_resources_dump_rt_subresources branch from 97a4346 to 41d8727 Compare August 28, 2024 13:02
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 245004.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4710 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4710 passed.

@davidlunarg
Copy link
Contributor

Changes look good. I ran the two CI dump resources tests I have handy on the CI systems against this branch and got good results. I had to merge this branch on top of the latest dev branch in order to get some of the tests to run. (The dev branch has a fix to avoid seg faults when running one of my CI tests.) Some of the dump resource output file names changed, so file comparisons failed (but the images in the files look good), but the archived file names can be changed once this PR is merged to dev. (That's a caution against changing output dump resources file names, it will break CI in the future.)

@panos-lunarg panos-lunarg force-pushed the vulkan_dump_resources_dump_rt_subresources branch from 41d8727 to ee5f4c2 Compare September 13, 2024 06:52
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 255348.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4821 running.

@panos-lunarg panos-lunarg force-pushed the vulkan_dump_resources_dump_rt_subresources branch from ee5f4c2 to 5e820df Compare September 13, 2024 06:56
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 255362.

@panos-lunarg panos-lunarg marked this pull request as ready for review September 13, 2024 07:00
@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4822 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4822 passed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 257879.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4842 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4842 passed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 258639.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4849 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4849 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 259015.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4858 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 4858 passed.

@davidlunarg
Copy link
Contributor

I ran the dump resources CI tests. (Manually, since the changes to CI infrastructure are not yet in the CI master branch.) There was a single failure, caused by the output file name change. Changes look good. We can rename the archive file name when dump resources is added to CI.

@panos-lunarg panos-lunarg merged commit 73202d3 into LunarG:dev Sep 19, 2024
8 checks passed
@panos-lunarg panos-lunarg deleted the vulkan_dump_resources_dump_rt_subresources branch September 19, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants