Add vkCmdInsertDebugUtilsLabelEXT as a frame delimiter #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 57615. |
|
CI gfxreconstruct build # 3359 running. |
|
CI gfxreconstruct build # 3359 passed. |
bradgrantham-lunarg
added
the
P2
marius-pelegrin-arm
force-pushed
the
debug-utils-frame-delimiter
branch
from
af667bf
to
2275cdd
Compare
|
CI gfxreconstruct build queued with queue ID 122882. |
marius-pelegrin-arm
force-pushed
the
debug-utils-frame-delimiter
branch
from
2275cdd
to
2014e8f
Compare
|
CI gfxreconstruct build queued with queue ID 122915. |
|
CI gfxreconstruct build # 3704 running. |
|
CI gfxreconstruct build # 3704 passed. |
Currently only vkCmdDebugMarkerInsertEXT (under conditions on the name of the marker) is considered a frame delimiter (aside from queue present). However, VK_EXT_debug_marker is deprecated and promoted to the VK_EXT_debug_utils extension that support an almost identical command vkCmdInsertDebugUtilsLabelEXT. This commit only add this command as a frame delimiter under the same conditions on the name of the label (which replaces the marker). Change-Id: Ic4164ee65eba2c1295ef8c45084ee6136dc796a8
MarkY-LunarG
force-pushed
the
debug-utils-frame-delimiter
branch
from
2014e8f
to
d286439
Compare
|
CI gfxreconstruct build queued with queue ID 207373. |
|
Force pushed a rebase on latest dev to resolve issues. |
|
CI gfxreconstruct build # 4320 running. |
|
CI gfxreconstruct build # 4320 passed. |
MarkY-LunarG
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only
vkCmdDebugMarkerInsertEXT(under conditions on the name of the marker) is considered a frame delimiter (aside from queue present).However,
VK_EXT_debug_markeris deprecated and promoted to theVK_EXT_debug_utilsextension that support an almost identical commandvkCmdInsertDebugUtilsLabelEXT.This commit only add this command as a frame delimiter under the same conditions on the name of the label (which replaces the marker).