Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write frame end markers to capture file #1191

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Write frame end markers to capture file #1191

merged 3 commits into from
Jul 19, 2023

Conversation

davidd-lunarg
Copy link
Contributor

When the capture manager encounters an end of frame, write an end of
frame marker to the capture file. When processing the file in the file
processor, if end of frame markers are present, use those instead of
specific API calls to track frame counts.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 4058.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 2955 running.

@davidd-lunarg
Copy link
Contributor Author

This PR is a prerequisite to PR #1138

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 2955 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 4569.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 2961 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 2961 passed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 5212.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 2968 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 2968 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 5368.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 2972 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 2972 passed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 6001.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 2976 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 2976 passed.

andrew-lunarg
andrew-lunarg reviewed Jul 13, 2023
View reviewed changes
Copy link
Contributor

@andrew-lunarg andrew-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, very educational read.

framework/decode/file_processor.h Outdated Show resolved Hide resolved
framework/decode/file_processor.cpp Outdated Show resolved Hide resolved
framework/decode/vulkan_export_json_consumer_base.h Show resolved Hide resolved
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 7862.

@ci-tester-lunarg
Copy link

CI gfxreconstruct-extended build queued with queue ID 7865.

@ci-tester-lunarg
Copy link

CI gfxreconstruct-extended build # 224 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 2986 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 2986 passed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct-extended build # 224 aborted.

@davidd-lunarg
Unify frame count vars in capture manager
ddcab19 
Remove `global_frame_count_` and always use `current_frame_`.
@davidd-lunarg
Write frame markers to capture file
0f3c7f4 
When the capture manager encounters an end of frame, write an end of
frame marker to the capture file. When processing the file in the file
processor, if end of frame markers are present, use those instead of
specific API calls to track frame counts.
@davidd-lunarg
Handle frame end markers in decoders & consumers
e631e3a
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 8051.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 2990 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 2990 passed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct-extended build queued with queue ID 8203.

@ci-tester-lunarg
Copy link

CI gfxreconstruct-extended build # 226 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct-extended build # 226 passed.

@davidd-lunarg davidd-lunarg merged commit 962341a into LunarG:dev Jul 19, 2023
@davidd-lunarg davidd-lunarg deleted the davidd-frame-end-markers branch July 19, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-lunarg andrew-lunarg andrew-lunarg left review comments

@bradgrantham-lunarg bradgrantham-lunarg Awaiting requested review from bradgrantham-lunarg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidd-lunarg @ci-tester-lunarg @andrew-lunarg