Add Dummy Heap #1165
Merged
Add Dummy Heap #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: --create-dummy-allocations not able to disturb PlacedResource allocation. There is chance that replay recreate PlacedResource at same GPUVA as capture. Solution: Create a dummy heap before real heap and then release it immediately.
|
CI gfxreconstruct build queued with queue ID 1197. |
|
CI gfxreconstruct build # 2891 running. |
|
CI gfxreconstruct build # 2891 failed. |
|
The LunarG CI failure was a system issue. I've addressed it and am restarting. |
|
CI gfxreconstruct build queued with queue ID 1260. |
|
CI gfxreconstruct build # 2892 running. |
|
CI gfxreconstruct build # 2892 passed. |
davidd-lunarg
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
--create-dummy-allocations not able to disturb PlacedResource allocation. There is chance that replay recreate PlacedResource at same GPUVA as capture.
Solution:
Create a dummy heap before real heap and then release it immediately.