Skip to content

Commit

Permalink
vkconfig3: Fix crash when no loader was found
Browse files Browse the repository at this point in the history
  • Loading branch information
christophe-lunarg committed Nov 15, 2024
1 parent 5648dcb commit 64701a1
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
3 changes: 2 additions & 1 deletion vkconfig_core/alert.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ QMessageBox::Button Alert::StartSingleton() {
void Alert::StartLoaderFailure() {
QMessageBox alert;
alert.QDialog::setWindowTitle("Vulkan Configurator failed to start...");
alert.setText("Could not find a Vulkan Loader.");
alert.setText("Could not find a Vulkan Loader. Please install the Vulkan SDK.");
alert.setInformativeText("<a href=\"https://vulkan.lunarg.com/sdk/home\">https://vulkan.lunarg.com/sdk/home</a>");
alert.setIcon(QMessageBox::Critical);
alert.exec();
}
Expand Down
14 changes: 7 additions & 7 deletions vkconfig_core/vulkan_util.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,13 @@ struct VulkanFunctions {
VulkanFunctions();
bool Validate() const;

PFN_vkEnumerateInstanceVersion EnumerateInstanceVersion;
PFN_vkEnumerateInstanceLayerProperties EnumerateInstanceLayerProperties;
PFN_vkEnumeratePhysicalDevices EnumeratePhysicalDevices;
PFN_vkEnumerateInstanceExtensionProperties EnumerateInstanceExtensionProperties;
PFN_vkCreateInstance CreateInstance;
PFN_vkDestroyInstance DestroyInstance;
PFN_vkGetPhysicalDeviceProperties2 GetPhysicalDeviceProperties2;
PFN_vkEnumerateInstanceVersion EnumerateInstanceVersion = nullptr;
PFN_vkEnumerateInstanceLayerProperties EnumerateInstanceLayerProperties = nullptr;
PFN_vkEnumeratePhysicalDevices EnumeratePhysicalDevices = nullptr;
PFN_vkEnumerateInstanceExtensionProperties EnumerateInstanceExtensionProperties = nullptr;
PFN_vkCreateInstance CreateInstance = nullptr;
PFN_vkDestroyInstance DestroyInstance = nullptr;
PFN_vkGetPhysicalDeviceProperties2 GetPhysicalDeviceProperties2 = nullptr;
};

static const char *GetVulkanLibrary() {
Expand Down

0 comments on commit 64701a1

Please sign in to comment.