-
Notifications
You must be signed in to change notification settings - Fork 305
Update Android build with gradle plugin version 4.0.0 #299
Conversation
cf64690
to
ddbec78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @ggfan Is there anything that can be done about all the Google Play store warnings?
ddbec78
to
42859ed
Compare
looks like CI is building for arm7, changing it to arm64-v8a might help. The problem is that my linux machine is down on campus ( I am WFH ), once it is booted again I could try more. Just added the above change to the CL, let's see how CI goes. Cody might need to review the CI changes: could we totally bypass NDK 15 install? |
Tony, I don't think there's active development on these samples any more right? They are old enough you could probably switch to the defaults available from Travis, rather than downloading the NDK each time. Same for gradle I think, per a quick scan of this document: |
Actually, these are periodically rolled into Google's samples here (https://github.com/googlesamples/vulkan-basic-samples/commits/master) so it makes sense to support newer toolchains. You can probably go with with these changes. Thanks Gerry! Does anything in BUILD.md need to be updated for the versions? |
Just tried the change to arm64-v8a and all the play store warnings go away. Everyone oh with that change? |
Nothing to do in BUILD.md. Pushed this and a change to the ABI used in Travis. |
yeah, I think we could drop a line or two inside BUILD.md, and I will give it a shot. Once checked in this PR ( Studio 4.0.0 version ), the behavior is:
Studio 4.2.0+ will auto-download a default NDK version to use, only if not configuring a NDK version to use. Just need to confirm that CI could take it if we comment out NDK-r15 version ( which is current version ) |
Oh I missed that it is already merged. thank you! |
A few of things: