Added tests for ccxt data. Standardized signature of get_last_price

[brettelliot]

Description by Korbit AI

What change is being made?

Enhance the codebase by standardizing the return type of get_last_price methods across various data source and broker modules to Union[float, Decimal, None] and introduce new tests specifically for the CCXT data source to improve coverage.

Why are these changes being made?

Standardizing the return type of get_last_price ensures consistency in handling the method's output, which can vary between float, Decimal, or be None, aligning with use cases requiring precise decimal operations often necessary in financial computations. Additionally, the new tests for the CCXT backtesting data source address coverage gaps providing assurance of its functionality across different market data and environments. These improvements prioritize the accuracy and reliability of financial calculations within the application.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

[korbit-ai]

Important

Required App Permission Update

Noise Reduction Improvements

This update requests write permissions for Commit Statuses in order to send updates directly to your PRs without adding comments that spam notifications. Visit our changelog to learn more.

Click here to accept the updated permissions

_{To accept the updated permissions, sufficient privileges are required}

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
lumibot/data_sources/example_broker_data.py	✅
lumibot/example_strategies/ccxt_backtesting_example.py	✅
lumibot/data_sources/yahoo_data.py	✅
lumibot/data_sources/ccxt_data.py	✅
lumibot/entities/bars.py	✅
lumibot/backtesting/polygon_backtesting.py	✅
lumibot/backtesting/thetadata_backtesting.py	✅
lumibot/data_sources/alpaca_data.py	✅
lumibot/data_sources/ccxt_backtesting_data.py	✅
lumibot/data_sources/interactive_brokers_data.py	✅
lumibot/data_sources/tradier_data.py	✅
lumibot/data_sources/pandas_data.py	✅
lumibot/data_sources/data_source.py	✅
lumibot/entities/data.py	✅
lumibot/data_sources/interactive_brokers_rest_data.py	✅
lumibot/brokers/broker.py	✅
lumibot/strategies/strategy.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

​

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	✅

Issue Categories

​

Category	Enabled
Naming	✅
Database Operations	✅
Documentation	✅
Logging	✅
Error Handling	✅
Systems and Environment	✅
Objects and Data Structures	✅
Readability and Maintainability	✅
Asynchronous Processing	✅
Design Patterns	✅
Third-Party Libraries	✅
Performance	✅
Security	✅
Functionality	✅

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ [email protected]

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here