Added support for fractional shares and crypto assets to the DriftRebalancer #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Korbit doesn't automatically review large (500+ lines changed) pull requests such as this one. If you want me to review anyway, use |
brettelliot
temporarily deployed
to
unit-tests
GitHub Actions
Inactive
grzesir
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can use fractional shares and/or create portfolios of crypto assets.
Description by Korbit AI
What change is being made?
Add support for fractional shares and crypto assets to the DriftRebalancer component, including updates to strategy examples, configuration files, and unit tests.
Why are these changes being made?
The DriftRebalancer previously only supported whole share quantities, which limited its flexibility for portfolios involving fractional shares and crypto assets that often require fractional transactions. Implementing support for fractional shares and adding the ability to handle crypto assets expands the capabilities of the rebalancer, making it more versatile and suitable for a broader range of investment strategies. The new implementation also includes documentation and tests to ensure accuracy and reliability in these operations.