Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.13 Support and Dependency Cleanup #658

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Python 3.13 Support and Dependency Cleanup #658

merged 4 commits into from
Dec 11, 2024

Conversation

Al4ise
Copy link
Collaborator

@Al4ise Al4ise commented Dec 9, 2024

Description by Korbit AI

What change is being made?

Eliminate the need for the Trader class in strategy execution by substituting its usage with the strategy.run_live() method, and update the requirements.txt and setup.py to reflect version updates and cleanup unused packages.

Why are these changes being made?

The simplification of strategy execution by directly running strategies with strategy.run_live() reduces complexity and improves code readability. This also aligns with modern best practices for live strategy execution, ensuring the codebase is more maintainable. Updating the dependencies in requirements.txt and setup.py ensures compatibility with new package versions, removes unused packages, and optimizes dependency management.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

Copy link
Contributor

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary by Korbit AI

Code Execution Comments

  • Address version constraints for dependencies: add constraint for exchange_calendars and relax ibapi pinning for updates.
Files scanned
File Path Reviewed
lumibot/example_strategies/simple_start_single_file.py
lumibot/example_strategies/lifecycle_logger.py
lumibot/example_strategies/forex_hold_to_expiry.py
lumibot/example_strategies/stock_bracket.py
lumibot/example_strategies/futures_hold_to_expiry.py
setup.py
lumibot/example_strategies/stock_oco.py
lumibot/example_strategies/stock_buy_and_hold.py
lumibot/example_strategies/options_hold_to_expiry.py
lumibot/example_strategies/stock_limit_and_trailing_stops.py
lumibot/example_strategies/stock_diversified_leverage.py
lumibot/example_strategies/crypto_important_functions.py
lumibot/example_strategies/stock_momentum.py
lumibot/credentials.py
lumibot/example_strategies/strangle.py

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Naming
Database Operations
Documentation
Logging
Error Handling
Systems and Environment
Objects and Data Structures
Readability and Maintainability
Asynchronous Processing
Design Patterns
Third-Party Libraries
Performance
Security
Functionality

Feedback and Support

"tqdm",
"lumiwealth-tradier>=0.1.14",
"pytz",
"psycopg2-binary",
"exchange_calendars>=4.5.2",
"exchange_calendars",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

category Functionality

Missing Version Constraint for Critical Trading Calendar Dependency

Tell me more

What is the issue?
The exchange_calendars dependency is missing a version constraint, which could lead to compatibility issues with future versions.

Why this matters
Without version constraints, automatic updates could introduce breaking changes that affect trading calendar functionality and market hours calculations.

Chat with Korbit by mentioning @korbit-ai, and give a 👍 or 👎 to help Korbit improve your reviews.

@@ -20,44 +20,29 @@
"ibapi==9.81.1.post1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

category Functionality

Overly Restrictive IBAPI Version Pinning

Tell me more

What is the issue?
The strict version pinning of ibapi could prevent important security and functionality updates.

Why this matters
Interactive Brokers API updates often include critical fixes and improvements for order execution and market data. Being locked to a specific version could miss these important updates.

Chat with Korbit by mentioning @korbit-ai, and give a 👍 or 👎 to help Korbit improve your reviews.

@Al4ise Al4ise changed the title 3.13-support Python 3.13 Support and Dependency Cleanup Dec 9, 2024
@grzesir grzesir merged commit af1a90c into dev Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants