remove logging of crash events

[brettelliot]

Description by Korbit AI

What change is being made?

Remove logging for crash events in drift_rebalancer.py.

Why are these changes being made?

The existing functions on_abrupt_closing and on_bot_crash were deemed unnecessary for the current operation of the strategy, likely due to improved crash handling elsewhere in the codebase, or because these events do not require logging for stability or debugging purposes. This change cleans up the code by removing these unused or redundant functions.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
lumibot/example_strategies/drift_rebalancer.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

​

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	✅

Issue Categories

​

Category	Enabled
Naming	✅
Database Operations	✅
Documentation	✅
Logging	✅
Error Handling	✅
Systems and Environment	✅
Objects and Data Structures	✅
Readability and Maintainability	✅
Asynchronous Processing	✅
Design Patterns	✅
Third-Party Libraries	✅
Performance	✅
Security	✅
Functionality	✅

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ [email protected]

[ghost]

i keep unsubscribing and i still keep getting mails, i want it to stop!!!!!! my gmail is getting spammed!!!!?????

…

On Thu, Dec 5, 2024 at 4:16 AM Brett Elliot ***@***.***> wrote: Merged #649 <#649> into be-dev. — Reply to this email directly, view it on GitHub <#649 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BIOKVG2IGDIMAJYRHZU2DRT2D7AQBAVCNFSM6AAAAABTBP5QKSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGUZTKMBYGM3TMNQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>