merging dev into be-dev #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Futures fix, example futures and forex strategies
update comments on get_momentum signature
Fixes for traider.get_historical_prices, and tests for several data sources.
IB Fixes for order objects
potential fix for the send update to cloud function
|
Korbit doesn't automatically review large (500+ lines changed) pull requests such as this one. If you want me to review anyway, use |
brettelliot
temporarily deployed
to
unit-tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description by Korbit AI
What change is being made?
Refactor order submission logic across multiple broker classes, implement relative imports for internal modules, and enhance data handling in the backtesting process.
Why are these changes being made?
The refactoring aims to unify the order submission process by implementing a consistent approach across different broker implementations, making it easier to maintain and extend. The use of relative imports improves module structure and prevents potential import errors in large projects. Enhancements in data handling, particularly in logging and strategy tracking, enable more reliable backtesting and performance monitoring, allowing for more accurate testing and results analysis.