add broadcast to log message #333
Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
The Korbit AI Mentor has reviewed your code. To discuss an issue, reply using the tag @korbit-ai-mentor.
Please leave a 👍 if this is helpful and 👎 if it is irrelevant.
| @@ -318,7 +318,7 @@ def risk_free_rate(self): | |||
|
|
|||
| # =======Helper methods======================= | |||
|
|
|||
| def log_message(self, message, color=None): | |||
| def log_message(self, message, color=None, broadcast=False): | |||
There was a problem hiding this comment.
The new 'broadcast' parameter in the 'log_message' function is not used anywhere in the function. This could lead to confusion for other developers who might expect this parameter to affect the function's behavior. If the parameter is not needed, consider removing it to avoid confusion. If it is needed, make sure to implement its functionality within the function.
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| setuptools.setup( | |||
| name="lumibot", | |||
| version="2.9.7", | |||
| version="2.9.8", | |||
There was a problem hiding this comment.
The version number has been updated in the setup.py file, but there is no information in the pull request description about what changes have been made that warrant this version update. It's important to provide this information so that other developers can understand what changes have been made and why the version number has been updated.
| @@ -318,7 +318,7 @@ def risk_free_rate(self): | |||
|
|
|||
| # =======Helper methods======================= | |||
|
|
|||
| def log_message(self, message, color=None): | |||
| def log_message(self, message, color=None, broadcast=False): | |||
There was a problem hiding this comment.
The 'broadcast' parameter is not documented in the function's docstring. It's important to keep the documentation up to date with the code to ensure that other developers can understand the purpose and usage of each parameter.
No description provided.