Hide errors from FilesEntity.Apply to match upstream.

holocm#19

src/holocm.org/plugins/files/entity.go

@@ -111,21 +111,26 @@ func (target *FilesEntity) EntityUserInfo() (r []holo.KV) {
 }
 
 func (target *FilesEntity) Apply(withForce bool, stdout, stderr io.Writer) holo.ApplyResult {
+	// BUG(lukeshu): FilesEntity.Apply: We hide errors here to
+	// match the upstream behavior of holo-files:
+	// https://github.com/holocm/holo/issues/19
 	if target.orphaned {
 		errs := target.handleOrphanedTargetBase()
 		if len(errs) > 0 {
 			for _, err := range errs {
 				fmt.Fprintf(stderr, "!! %s\n", err.Error())
 			}
-			return holo.NewApplyError(errs[0])
+			//return holo.NewApplyError(errs[0])
+			return holo.ApplyApplied
 		}
 		return holo.ApplyApplied
 	} else {
 		result, err := target.apply(withForce)
 
 		if err != nil {
 			fmt.Fprintf(stderr, "!! %s\n", err.Error())
-			return holo.NewApplyError(err)
+			//return holo.NewApplyError(err)
+			return holo.ApplyApplied
 		}
 
 		return result