Implement weekly breakdown CI job #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this throw off the weekly data with GHA cron not lining up with existing weekly records? |
|
"weekly" is just how the seed script did it. The date is whatever it says in the json (should be plotted as XY, not assuming linear time axis). If that's too hard, it could be moved to ~Tuesday (depending on timezones). |
|
I don't think it currently handles time properly, but it would be an easy enough fix more just the perfectionist in me wanting a week gap always. |
|
FWIW, I haven't figured out how it works with timezones. Currently the last sample is 2023-09-19, which would mean the next is 26th (Tuesday). Google tells me github is UTC. Changed GHA to 01:00 every Tuesday |
|
tyvm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #265