Singletons lifetime parameters

libs/pavex_cli/tests/ui_tests/dependency_injection/lifecycles/non_static_references_cannot_be_singletons/expectations/stderr.txt

@@ -1,7 +1,7 @@
 ERROR: 
   × `&app::B` can't be a singleton because its lifetime isn't `'static`.
   │ Singletons must be available for as long as the application is running,
-  │ therefore they their lifetime must be `'static`.
+  │ therefore their lifetime must be `'static`.
   │
   │     ╭─[src/lib.rs:25:1]
   │  25 │     bp.constructor(f!(crate::a), Lifecycle::Singleton);

libs/pavex_cli/tests/ui_tests/dependency_injection/lifecycles/non_static_references_cannot_be_singletons/test_config.toml

@@ -1,5 +1,4 @@
-description = """Singletons can only depend on other singletons, they can't depend on 
-request-scoped or transient components"""
+description = """Singletons cannot be non-'static references"""
 
 [expectations]
 codegen = "fail"

libs/pavex_cli/tests/ui_tests/dependency_injection/lifecycles/singletons_cannot_have_non_static_lifetime_parameters/expectations/stderr.txt

@@ -0,0 +1,16 @@
+ERROR: 
+  × `app::B<'a>` can't be a singleton because at least one of its lifetime
+  │ parameters isn't `'static`.
+  │ Singletons must be available for as long as the application is running,
+  │ therefore their lifetime must be `'static`.
+  │
+  │     ╭─[src/lib.rs:26:1]
+  │  26 │     bp.singleton(f!(self::a));
+  │  27 │     bp.singleton(f!(self::B::new)).clone_if_necessary();
+  │     ·                  ────────┬───────
+  │     ·                          ╰── The singleton was registered here
+  │  28 │     bp.route(GET, "/", f!(self::handler));
+  │     ╰────
+  │   help: If your type holds a reference to data that's owned by another
+  │         singleton component, register its constructor as transient rather
+  │         than singleton.

libs/pavex_cli/tests/ui_tests/dependency_injection/lifecycles/singletons_cannot_have_non_static_lifetime_parameters/lib.rs

@@ -0,0 +1,30 @@
+use pavex::blueprint::{router::GET, Blueprint};
+use pavex::f;
+use pavex::http::StatusCode;
+
+pub struct A;
+
+#[derive(Clone)]
+pub struct B<'a>(&'a A);
+
+impl<'a> B<'a> {
+    pub fn new(a: &'a A) -> Self {
+        B(a)
+    }
+}
+
+pub fn a() -> A {
+    todo!()
+}
+
+pub fn handler<'a>(_b: B<'a>) -> StatusCode {
+    todo!()
+}
+
+pub fn blueprint() -> Blueprint {
+    let mut bp = Blueprint::new();
+    bp.singleton(f!(self::a));
+    bp.singleton(f!(self::B::new)).clone_if_necessary();
+    bp.route(GET, "/", f!(self::handler));
+    bp
+}

libs/pavex_cli/tests/ui_tests/dependency_injection/lifecycles/singletons_cannot_have_non_static_lifetime_parameters/test_config.toml

@@ -0,0 +1,4 @@
+description = """Singletons cannot have non-'static lifetime parameters"""
+
+[expectations]
+codegen = "fail"

libs/pavexc/src/compiler/analyses/components/db/diagnostics.rs

@@ -1089,7 +1089,7 @@ impl ComponentDb {
         let error = anyhow::anyhow!(
             "`{output_type:?}` can't be a singleton because its lifetime isn't `'static`.\n\
             Singletons must be available for as long as the application is running, \
-            therefore they their lifetime must be `'static`.",
+            therefore their lifetime must be `'static`.",
         );
         let d = CompilerDiagnostic::builder(error)
             .optional_source(source)
@@ -1101,4 +1101,36 @@ impl ComponentDb {
             .build();
         diagnostics.push(d.into());
     }
+
+    pub(super) fn non_static_lifetime_parameter_in_singleton(
+        output_type: &ResolvedType,
+        user_component_id: UserComponentId,
+        user_component_db: &UserComponentDb,
+        package_graph: &PackageGraph,
+        diagnostics: &mut Vec<miette::Error>,
+    ) {
+        let location = user_component_db.get_location(user_component_id);
+        let source = try_source!(location, package_graph, diagnostics);
+        let label = source
+            .as_ref()
+            .map(|source| {
+                diagnostic::get_f_macro_invocation_span(&source, location)
+                    .labeled("The singleton was registered here".into())
+            })
+            .flatten();
+        let error = anyhow::anyhow!(
+            "`{output_type:?}` can't be a singleton because at least one of its lifetime parameters isn't `'static`.\n\
+            Singletons must be available for as long as the application is running, \
+            therefore their lifetime must be `'static`.",
+        );
+        let d = CompilerDiagnostic::builder(error)
+            .optional_source(source)
+            .optional_label(label)
+            .help(
+                "If your type holds a reference to data that's owned by another singleton component, \
+                register its constructor as transient rather than singleton.".into(),
+            )
+            .build();
+        diagnostics.push(d.into());
+    }
 }

libs/pavexc/src/compiler/analyses/components/db/mod.rs

@@ -592,6 +592,18 @@ impl ComponentDb {
                                     diagnostics,
                                 );
                             }
+                        } else {
+                            if output_type.has_implicit_lifetime_parameters()
+                                || !output_type.named_lifetime_parameters().is_empty()
+                            {
+                                Self::non_static_lifetime_parameter_in_singleton(
+                                    output_type,
+                                    user_component_id,
+                                    &self.user_component_db,
+                                    package_graph,
+                                    diagnostics,
+                                );
+                            }
                         }
                     }