-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
urlencoded extractor #255
urlencoded extractor #255
Conversation
/ok-to-test sha=ee40371 |
|
||
#[doc(alias = "UrlEncoded")] | ||
#[derive(Debug)] | ||
/// Parse the body of an incoming request as an application/x-www-form-urlencoded form. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this should go in a new guide section under this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify, shall I keep the comments in the code, and add a section under docs for urlencoded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will look at how you have done JsonBody and mimic that one, to make it consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LukeMathWalker how does this seem?
Can you fill in https://github.com/LukeMathWalker/pavex/blob/main/CONTRIBUTORS.md? |
/ok-to-test sha=1714a76 |
Should I include anything in the docs about the fact that nested fields will not be supported? |
Yes, let's explain it! |
/ok-to-test sha=6c38d9d |
No description provided.