-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version management #1: introducing pavexc
#163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not hardcore a SHA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's wrong
For Pavex to work as expected, the version of the CLI used when compiling a project with
cargo px [...]
must match the version of thepavex
library crate used in the project.Currently, there's no mechanism to ensure this is the case. As a result, you'll get version mismatches, resulting in confusing errors (see @m1guelpf in #131).
The problem is even worse if you have multiple Pavex projects, each using a different library version: you'd have to juggle multiple CLI versions on your own since they can't all be in the
PATH
.The solution
To eliminate the problem, this PR reworks the
pavex
CLI: it is now a version manager.All the meaty functionality (server SDK generation, project generation) is moved into another binary,
pavexc
(pavex compiler).pavex
introduces the concept of toolchains, in the same vein ofrustup
. There can be multiple toolchains installed and it'll pick the most appropriate one for each command:new
, it'll check the default toolchain. If none has been defined, it'll use the corresponding version ofpavexc
.generate
, it'll match the version ofpavex
(the library) used in the project. If the correspondingpavexc
toolchain is not installed, it'll be installed on the fly.Missing pieces
The
pavex
CLI needs to grow a few commands to manage toolchains:pavex toolchain default set
,pavex toolchain default show
,pavex toolchain list
and something for removal.Since they are only relevant for
pavex new
, that's deferred to a later PR.