Add wrapping behaviour to code labels #116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our error reporter had no wrapping behaviour for code labels: they would happily go as far right as they wanted, often overflowing the assumed width of the terminal they are being printed on.
This PR changes that behaviour in two ways:
Getting this right was... tricky. But we have a fairly extensive collection of error messages in our UI tests and the new version seems to work as expected.