urlencoded extractor #255
Merged
urlencoded extractor #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test sha=ee40371 |
|
|
||
| #[doc(alias = "UrlEncoded")] | ||
| #[derive(Debug)] | ||
| /// Parse the body of an incoming request as an application/x-www-form-urlencoded form. |
There was a problem hiding this comment.
Most of this should go in a new guide section under this one
There was a problem hiding this comment.
Just to clarify, shall I keep the comments in the code, and add a section under docs for urlencoded?
There was a problem hiding this comment.
I will look at how you have done JsonBody and mimic that one, to make it consistent.
There was a problem hiding this comment.
@LukeMathWalker how does this seem?
|
Can you fill in https://github.com/LukeMathWalker/pavex/blob/main/CONTRIBUTORS.md? |
|
/ok-to-test sha=1714a76 |
|
Should I include anything in the docs about the fact that nested fields will not be supported? |
|
Yes, let's explain it! |
|
/ok-to-test sha=6c38d9d |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.