Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AndroidMopups.cs #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update AndroidMopups.cs #152

wants to merge 1 commit into from

Conversation

AnthonyNjuguna
Copy link

Potential fix for popups appearing behind modals in android - fixes #143 & #144

Credit to @DashTheDev for finding the solution

@luisabreu84
Copy link

Thanks for this PR! We look forward to approval and release of a new version of the package.

@AlejandroBustosTrimble AlejandroBustosTrimble mentioned this pull request Feb 5, 2025
Closed
AlejandroBustosTrimble
AlejandroBustosTrimble approved these changes Feb 5, 2025
View reviewed changes
Copy link

@AlejandroBustosTrimble AlejandroBustosTrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my company project, its works ok! (it fix the android issue related that was showing the popup on background)

@neretash
Copy link

@LuckyDucko 😃

@seanrodda
Copy link

Amazing, thanks for the fix. Is there a way to include this in our own solution before the release? or do you expect a new Mopup release soon?

@IeuanWalker
Copy link
Contributor

IeuanWalker commented Feb 12, 2025 •
edited
Loading

@seanrodda you can clone the PR, and add Mopups.csproj as a project reference and remove the NuGet reference until the fix is released

@seanrodda
Copy link

@seanrodda you can clone the PR, and add Mopups.csproj as a project reference and remove the NuGet reference until the fix is released

@IeuanWalker Good point. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlejandroBustosTrimble AlejandroBustosTrimble AlejandroBustosTrimble approved these changes

@mstristan mstristan mstristan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Popup displayed behind modal
7 participants
@AnthonyNjuguna @luisabreu84 @neretash @seanrodda @IeuanWalker @AlejandroBustosTrimble @mstristan