[Callout] Set callout state input multiple times doesn't work #3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-drouard
changed the title
g-drouard
force-pushed
the
fix-callout-state-multiple-updates
branch
2 times, most recently
from
082c788
to
7ac4423
Compare
g-drouard
force-pushed
the
fix-callout-state-multiple-updates
branch
from
7ac4423
to
62c3bf7
Compare
g-drouard
force-pushed
the
fix-callout-state-multiple-updates
branch
2 times, most recently
from
c04eeb2
to
bf12ab1
Compare
…a better management of callout state
g-drouard
force-pushed
the
fix-callout-state-multiple-updates
branch
from
bf12ab1
to
a490b04
Compare
Supamiu
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When callout state input was updated multiple times without icon and palette inputs then the palette and icon doesn't refresh with state value.
The callout state input setter was modifying other palette and icon inputs instead of just rendering.
N.B.
This problem would have been detected using signal inputs because it's not writable signals.