Fix form field margins #3058
Open
Fix form field margins #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvalentin-lucca
added
the
🔖🐛 FIX
| @@ -8,6 +8,10 @@ | |||
| margin: 0; | |||
| padding: 0; | |||
| border: 0; | |||
|
|
|||
| .form-field { | |||
| margin-block: var(--pr-t-spacings-50); | |||
There was a problem hiding this comment.
Should the last block always have a bottom-margin?
Actually, do we always want block margins here? For example, if we use a vertical flex container with gap?
There was a problem hiding this comment.
In this case, the container is always a .form-fieldset, and its display shouldn't move.
| @@ -8,6 +8,10 @@ | |||
| margin: 0; | |||
| padding: 0; | |||
| border: 0; | |||
|
|
|||
| .form-field { | |||
| margin-block: var(--pr-t-spacings-50); | |||
There was a problem hiding this comment.
Applying only a margin bottom on .formLabel and .form-field wouldn't be cleaner?
There was a problem hiding this comment.
That would work too, but it affects two elements instead of one.
The margins merge here, is that what's bothering you?
There was a problem hiding this comment.
I just wonder if margins collapse works well on every browsers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before:
After:
