feat(comment): basic angular wrapper implementation #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supamiu
added
👥 Front
…r-inte' into feat/comment-wrapper # Conflicts: # packages/ng/comment/comment-block/comment-block.component.html # packages/ng/comment/comment-block/comment-block.component.ts # packages/ng/comment/comment/comment.component.html # packages/ng/comment/comment/comment.component.ts # stories/documentation/texts/comment/angular.stories.ts
jeremie-lucca
requested changes
Oct 7, 2024
| @@ -0,0 +1,3 @@ | |||
| <ol class="commentWrapperChat"> | |||
There was a problem hiding this comment.
I wonder if this shouldn't be considered as a new component as I heard Clément speaking about "Chatbox". I'll investigate.
|
|
||
| &.mod-WrapperAvatar ~ &:not(.mod-WrapperAvatar) { | ||
| padding-left: var(--components-comment-content-margin); |
There was a problem hiding this comment.
Is there a reason behind this deletion?
It seems to break the comment's wrap (with avatar only on first comment) :
jeremie-lucca
added
the
💥 Breaking change
|
(Waiting design feedback on components naming before mergin') |
jeremie-lucca
previously approved these changes
Oct 11, 2024
jeremie-lucca
approved these changes
Oct 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The comment component is used to display comments or discussions on blocks
Each block is composed of informations about the author (
avatar, aTemplateRefandauthorName, aPortalContent(string | TemplateRef)) and handles comments that are placed inside of it as childlu-commentcomponents.