Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track HTTP request version #450

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Track HTTP request version #450

merged 1 commit into from
Jan 4, 2025

Conversation

LucasPickering
Copy link
Owner

@LucasPickering LucasPickering commented Jan 4, 2025

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

Track HTTP request version in the DB. reqwest uses HTTP/1.1 by default, and we've never allowed customization, so all historical requests will have used that version.

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

This is kinda dead code for now because there's no way to customize the version yet, but that's coming next.

QA

How did you test this?

Ran some tests manually, nothing much else to test yet.

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

@LucasPickering LucasPickering enabled auto-merge (rebase) January 4, 2025 18:19
@LucasPickering LucasPickering merged commit cc08265 into 3.0 Jan 4, 2025
15 checks passed
@LucasPickering LucasPickering deleted the http-version branch January 4, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant