Added connection & read timeout configuration for pushgateway sink #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are other issues that are related to the pushgateway implementation, no keep-alive on the connection, no connection pooling, no batching, we can fix these as well, but not in the context of this PR. |
|
@LucaCanali Is it possible to get a review? Thanks! |
|
Thank you @Arnovsky for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, this PR adds the capability to configure the timeout for the PushGateway http connection, we have observed cases where large spark jobs (hundreds - thousands) of stages are lagging due to the generous 5000ms default timeout, our aim is to allow this behaviour to be configurable.
I also fixed some inconsistencies with the formatting, please let me know if this is an issue and you'd like me to revert.