Revert "Merge branch 'lua-51-testsuite'" #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LuaJIT-test-cleanup into lua-51-testsuite" This reverts commit 7b022d4, reversing changes made to b116313.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the merge of branch
lua-51-testsuiteinto master. This would be one way to achieve what @dibyendumajumdar suggests in #8 (comment).The effect of merging this PR would be to revert the changes introduced on that branch while still keeping a stable history on master (no rebases). If whoever is maintaining the master branch does want to revert this version of the lua-51-testsuite, and does want to keep a stable history on the master branch, then they could consider merging this PR.
If in the future we do more work on the
lua-51-testsuitebranch and want to merge it again then the solution would be to first revert this revert and then do a new merge for the newer changes:See How to revert a faulty merge for full details.