Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to payjoin-0.21 #36

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Update to payjoin-0.21 #36

wants to merge 4 commits into from
+2,289 −2,707

Conversation

DanGould
Copy link
Contributor

@DanGould DanGould commented Oct 31, 2024 •
edited
Loading

  • 1st commit wildly simplifies lib.rs with pub use and wildcard exports
  • 2nd commit matches feature name danger-local-https
  • 3rd commit creates new modules to more closely match the rust-payjoin source it wraps
  • 4th commit exports lib.rs types within their module instead of at the root with a wildcard
  • 5th actually binds to 0.21 prerelease including passing integration tests

I haven't updated the UDL files with any updates to the actual bindings or touched the the python code yet

@DanGould DanGould force-pushed the simplify branch 5 times, most recently from 024b334 to 3bf8a7e Compare November 1, 2024 17:41
@DanGould
Fix type visibility
711b453 
Add compilation flags so tests don't cause build problems.
Simplify lib.rs with `pub use ...::*` wildcards.
@DanGould
Name danger-local-https
98b5e13
@DanGould
Replicate rust-payjoin directory structure
7586ec6 
Add bitcoin, ohttp, request modules. Remove types module.
@DanGould DanGould force-pushed the simplify branch 4 times, most recently from 53460a9 to c96d28c Compare November 13, 2024 04:22
@DanGould
Upgrade to unreleased payjoin-0.21
c96d28c 
Remove support for v1 send,receive code. Separate uniffi exports where
wrappers are required in order to support payjoin-flutter and other
non-uniffi bindings. Use procedural macros to define uniffi bindings.

Irrelevant v1-to-v1 tests were removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DanGould