Upgrade to bdk ffi v0.31.0 #72
Conversation
There was a problem hiding this comment.
I was concerned at first that moving every function in a separate thread would break functionality (I vaguely remember something breaking, when I tried that)
However, after compiling the update and checking through every bit of functionality we use at Peach, I can confirm that all keeps working well on Android and iOS 👌
ios/BdkRnModule.swift
Outdated
| @@ -472,16 +522,12 @@ class BdkRnModule: NSObject { | |||
| resolve: @escaping RCTPromiseResolveBlock, | |||
| reject: @escaping RCTPromiseRejectBlock | |||
| ) { | |||
| DispatchQueue.global().async { [self] in | |||
| DispatchQueue.main.async { [self] in | |||
There was a problem hiding this comment.
On second glance, I found that DispatchQueue.main is render blocking and very noticeable here as a user, because the UI freezes
There was a problem hiding this comment.
Interestingly, the change in the PR was meant to avoid UI thread blocking.
Will check your PR and this once again
|
Unfortunately after the last commit, my app keeps crashing right at startup. |
|
This is another issue caused by the upgrade: #75 |
Hi @Czino |
|
Unfortunately the demo does not run at all for me Looks like some extra steps are needed to make it run on my machine. |
| else -> { | ||
| resolvedIndex = setAddressIndex("new") | ||
| } | ||
| } | ||
| val addressInfo = getWalletById(id).getInternalAddress(setAddressIndex(resolvedIndex)) | ||
|
|
||
| val addressInfo = getWalletById(id).getAddress(setAddressIndex(resolvedIndex)) |
There was a problem hiding this comment.
Is this change on purpose? The ios/BdkRnModule.swift remains unchanged for this method.
Fixed getInternalAddress typo for Android
[0.31.0]
APIs Changed:
BumpFeeTxBuilder.allowShrinking()now takes aScriptas its argument.Addressconstructor now takes aNetworkargument.Payload::PubkeyHashandPayload::ScriptHashnow have string arguments instead of byte arrays.APIs Added:
Addresstype now has theisValidForNetwork()method.[0.30.0]
APIs added
BIP-86descriptor templates