Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom dimensions of the map #3

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Custom dimensions of the map #3

merged 2 commits into from
Oct 31, 2023

Conversation

rodrigo-ldc
Copy link
Contributor

Map CSS as a block to allow interaction when routing. The user can now specify the height and width of the map's pane when running the server

geeservermap --width 500 --height 800

Copy link
Member

@12rambau 12rambau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the templates use the html extension when they are in fact jinja2 files ?

@rodrigo-ldc
Copy link
Contributor Author

sorry @12rambau, can you explain a bit more? flask uses jinja2 yes (https://flask.palletsprojects.com/en/2.3.x/templating/)... what other extension could it have?

@12rambau
Copy link
Member

.jinja2

@12rambau
Copy link
Member

but I checked flask documentation and it seems commonly accepted to make it transparent

Copy link
Member

@12rambau 12rambau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

putting this one on stale until #4 is merged

@12rambau 12rambau merged commit d27f374 into main Oct 31, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants