Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): components lifecycle management in strict mode #408

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

theashraf
Copy link
Member

Description

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This is something we need to do.

Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: 5fcc374

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lottiefiles/dotlottie-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Coverage Report for @lottiefiles/dotlottie-web (packages/web)

Status Category Percentage Covered / Total
🟢 Lines 52.94% (🎯 30%) 558 / 1054
🟢 Statements 51.64% (🎯 30%) 582 / 1127
🟢 Functions 52.74% (🎯 30%) 144 / 273
🟢 Branches 58.23% (🎯 30%) 382 / 656
File CoverageNo changed files found.
Generated in workflow #1505 for commit 5fcc374 by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Nov 22, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
@lottiefiles/dotlottie-web 38.4 KB (0%) 768 ms (0%) 204 ms (-37.28% 🔽) 972 ms
@lottiefiles/dotlottie-web WASM 400 KB (0%) 8.1 s (0%) 0 ms (+100% 🔺) 8.1 s
@lottiefiles/dotlottie-react 41.22 KB (-0.97% 🔽) 825 ms (-0.97% 🔽) 410 ms (+90.01% 🔺) 1.3 s
@lottiefiles/dotlottie-vue 45.28 KB (0%) 906 ms (0%) 238 ms (-68.48% 🔽) 1.2 s
@lottiefiles/dotlottie-wc 45.37 KB (0%) 908 ms (0%) 330 ms (+55.38% 🔺) 1.3 s
@lottiefiles/dotlottie-svelte 45.87 KB (0%) 918 ms (0%) 181 ms (-11.25% 🔽) 1.1 s
@lottiefiles/dotlottie-solid 44.73 KB (0%) 895 ms (0%) 140 ms (-32.72% 🔽) 1.1 s

@theashraf theashraf force-pushed the fix/react-strict-mode branch 2 times, most recently from 5a21dba to 2f690f6 Compare November 22, 2024 10:53
@theashraf theashraf changed the title fix(react): strict mode fix(react): components lifecycle management in strict mode Nov 22, 2024
@theashraf theashraf changed the base branch from main to alpha November 22, 2024 10:54
@theashraf theashraf force-pushed the fix/react-strict-mode branch from 2f690f6 to 5fcc374 Compare November 22, 2024 10:57
@theashraf theashraf marked this pull request as ready for review November 22, 2024 10:58
@theashraf theashraf merged commit 94884b5 into alpha Nov 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant