Skip to content

Commit

Permalink
fix: 🐛 update method return value (#17)
Browse files Browse the repository at this point in the history
  • Loading branch information
theashraf authored Oct 30, 2023
1 parent 7760351 commit 66e9469
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions packages/web/src/dotlottie.ts
Original file line number Diff line number Diff line change
Expand Up @@ -147,15 +147,7 @@ export class DotLottie {

this._currentFrame = Math.max(0, Math.min(this._currentFrame, this._totalFrame - 1));

if (!this._renderer?.frame(this._currentFrame)) {
console.error(this._renderer?.error());

// eslint-disable-next-line no-warning-comments
// TODO: should return false, but would stop the animation loop
return true;
}

return true;
return this._renderer?.frame(this._currentFrame) ?? false;
}

/**
Expand Down
Binary file modified packages/web/src/renderer-wasm/bin/renderer.wasm
Binary file not shown.

0 comments on commit 66e9469

Please sign in to comment.