Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade thorvg v1.0-pre10 #244

Merged
merged 1 commit into from
Jan 15, 2025
Merged

feat: upgrade thorvg v1.0-pre10 #244

merged 1 commit into from
Jan 15, 2025

Conversation

theashraf
Copy link
Member

@theashraf theashraf commented Oct 11, 2024

Changes

  1. Feature Flags for thorvg Versions

    • Added two feature flags: thorvg-v1 and thorvg-v0.
    • These allow us to maintain compatibility with thorvg v0.x.x, as binaries for Linux, Windows, and macOS from the Conan registry currently only support v0.
    • thorvg-v1 is a pre-release version and is not yet stable or available on Conan.
  2. Default Configuration

    • By default, the thorvg-v0 flag is enabled for the FFI, unless explicitly specified otherwise.
  3. Build Target Differences

    • WebAssembly (WASM), Android, and Apple builds use thorvg-v1.
    • Native dependencies (Linux/Windows/macOS) use `thorvg-v0

WASM/APPLE/ANDROID artifacts -> https://github.com/LottieFiles/dotlottie-rs/actions/runs/12764709359

Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: 86d7377

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theashraf
Copy link
Member Author

Breaking changes in the new version
image

@theashraf
Copy link
Member Author

theashraf commented Oct 11, 2024

update thorvg version to 1.0-pre1 in Conan registry
conan-io/conan-center-index#25592

@theashraf theashraf changed the title chore: Update thorvg v1.0-pre1 chore: update thorvg v1.0-pre7 Dec 9, 2024
@theashraf theashraf force-pushed the chore/thorvg-1.0-pre1 branch 2 times, most recently from aa24c96 to bdac0e2 Compare December 10, 2024 06:55
@theashraf theashraf changed the title chore: update thorvg v1.0-pre7 feat: upgrade thorvg v1.0-pre7 Dec 10, 2024
@theashraf
Copy link
Member Author

theashraf commented Dec 10, 2024

thorvg v1 rendering regression issue -> thorvg/thorvg#3039

@theashraf theashraf force-pushed the chore/thorvg-1.0-pre1 branch from 88bf479 to 2158fd6 Compare December 13, 2024 15:12
@theashraf theashraf changed the title feat: upgrade thorvg v1.0-pre7 feat: upgrade thorvg v1.0-pre8 Dec 14, 2024
@theashraf theashraf changed the title feat: upgrade thorvg v1.0-pre8 feat: upgrade thorvg v1.0-pre10 Jan 10, 2025
@theashraf theashraf force-pushed the chore/thorvg-1.0-pre1 branch 2 times, most recently from 1a20c6c to c6862a0 Compare January 10, 2025 03:48
@theashraf theashraf force-pushed the chore/thorvg-1.0-pre1 branch from a7f1955 to 3bf976f Compare January 13, 2025 09:36
@theashraf theashraf requested a review from afsalz January 14, 2025 09:58
@theashraf theashraf merged commit 3be0e16 into main Jan 15, 2025
4 checks passed
@github-actions github-actions bot mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants