Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: 🎡 use [email protected] for wasm target only #137

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

theashraf
Copy link
Member

@theashraf theashraf commented Apr 17, 2024

Context:

  • WASM bindings are generated from the C++ bindings created by uniffi-bindgen-cpp.
  • uniffi-bindgen-cpp supports only [email protected]. Therefore, we need to dynamically downgrade the uniffi version from v0.27 to v0.25 when building for WASM.

Changes:

  • Created Cargo.wasm.toml, which is a modified copy of the default Cargo.toml, but with [email protected] instead of [email protected].
  • Updated the Makefile to include two steps: pre-make-wasm and post-make-wasm. The pre-make wasm step copies the contents of Cargo.wasm.toml to the default Cargo.toml, and the post-make-wasm step cleans it up, restoring the original Cargo.toml.

These changes will ensure that the WASM release assets function properly, eliminating the need to build WASM locally for release

Copy link

changeset-bot bot commented Apr 17, 2024

⚠️ No Changeset found

Latest commit: 0d0cf36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theashraf theashraf marked this pull request as ready for review April 17, 2024 13:17
@theashraf theashraf force-pushed the fix/wasm-uniffi-version branch from 2e3503f to 0d0cf36 Compare April 17, 2024 13:18
@theashraf
Copy link
Member Author

@theashraf theashraf self-assigned this Apr 17, 2024
@theashraf theashraf requested a review from samuelOsborne April 17, 2024 13:48
@theashraf theashraf merged commit 5ed5fbc into main Apr 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants