-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add active_theme_id
function
#131
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jk-gan, overall, it looks great!
Just one comment I have:
Loading a new animation should clear the active theme ID, so we need to do that in the following methods:
load_animation_data
load_animation_path
load_dotlottie_data
Also, we can add another assertion to ensure the active_theme_id
becomes empty after another load request for both dotLottie and Lottie animations.
I've updated the PR @theashraf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@jk-gan Thanks for your contribution!
Changes
active_theme_id
method to theDotLottiePlayer
, to return the loaded theme idactive_theme_id
is updated correctlyactive_theme_id
function to CPP/Kotlin/SwiftClose #119
I refer @theashraf implementation in #125.