Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 💡 wasm size optimization #103

Closed
wants to merge 3 commits into from
Closed

Conversation

theashraf
Copy link
Member

@theashraf theashraf commented Mar 20, 2024

Changes:

  • minimize the dotlottie-rs dependencies
    • get rid of serde, json, and base64
  • dotlottie_player only cares about the extraction from zip and deserialization of some assets, so the serialization process is not needed. It's the concern of the dotlottie-fms crate, so we can have a lighter dotlottie_manager (aka dotlottie_loader) to help serve the dotLottie file assets.
  • refactor a few functions for size.

Updates:

  • reduced the original wasm size from 707kb to 618kb as of now 👀

Related #107

Copy link

changeset-bot bot commented Mar 20, 2024

⚠️ No Changeset found

Latest commit: e48bb04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theashraf
Copy link
Member Author

I am closing this pull request and will submit incremental pull requests that include micro optimizations for the WebAssembly binary instead

@theashraf theashraf closed this Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant