add msg_server test

app/modules.go

@@ -139,6 +139,7 @@ var (
 		agent.AppModuleBasic{},
 		plan.AppModuleBasic{},
 		token.AppModuleBasic{},
+		ccev.AppModuleBasic{},
 	)
 
 	// module account permissions

x/ccev/keeper/contract.go

@@ -1,6 +1,7 @@
 package keeper
 
 import (
+	errorsmod "cosmossdk.io/errors"
 	"github.com/Lorenzo-Protocol/lorenzo/v3/x/ccev/types"
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	"github.com/ethereum/go-ethereum/common"
@@ -14,14 +15,18 @@ func (k Keeper) UploadContract(
 	address string,
 	eventName string,
 	abi []byte,
-) {
+) error {
+	if !k.hasClient(ctx, chainID) {
+		return errorsmod.Wrapf(types.ErrNotFoundClient, "client %d not found", chainID)
+	}
 	contract := &types.Contract{
 		ChainId:   chainID,
 		Address:   address,
 		EventName: eventName,
 		Abi:       abi,
 	}
 	k.setContract(ctx, contract)
+	return nil
 }
 
 func (k Keeper) setContract(ctx sdk.Context, contract *types.Contract) {
@@ -47,7 +52,7 @@ func (k Keeper) getContract(
 	return &contract
 }
 
-func (k Keeper) getAllContracts(ctx sdk.Context,chainID uint32) (contracts []*types.Contract) {
+func (k Keeper) getAllContracts(ctx sdk.Context, chainID uint32) (contracts []*types.Contract) {
 	store := k.clientStore(ctx, chainID)
 
 	it := sdk.KVStorePrefixIterator(store, types.KeyPrefixCrossChainContract)

x/ccev/keeper/header.go

@@ -48,6 +48,9 @@ func (k Keeper) UploadHeaders(ctx sdk.Context, chainID uint32, headers []types.T
 	}
 
 	for _, header := range headers {
+		if k.HasHeader(ctx, chainID, header.Number) {
+			return errorsmod.Wrapf(types.ErrDuplicateHeader, "header %d already exists", header.Number)
+		}
 		k.setHeader(ctx, chainID, &header)
 	}
 	k.setLatestNumber(ctx, chainID, headers[len(headers)-1].Number)

x/ccev/keeper/keeper_test.go

@@ -0,0 +1,67 @@
+package keeper_test
+
+import (
+	"encoding/json"
+	"testing"
+
+	tmproto "github.com/cometbft/cometbft/proto/tendermint/types"
+	"github.com/cosmos/cosmos-sdk/baseapp"
+	"github.com/cosmos/cosmos-sdk/codec"
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	"github.com/stretchr/testify/suite"
+
+	"github.com/Lorenzo-Protocol/lorenzo/v3/app"
+	"github.com/Lorenzo-Protocol/lorenzo/v3/x/ccev/keeper"
+	"github.com/Lorenzo-Protocol/lorenzo/v3/x/ccev/types"
+)
+
+var testAccounts = app.CreateTestAddrs(2)
+
+type KeeperTestSuite struct {
+	suite.Suite
+
+	ctx    sdk.Context
+	keeper keeper.Keeper
+
+	msgServer   types.MsgServer
+	queryClient types.QueryClient
+}
+
+func TestKeeperTestSuite(t *testing.T) {
+	suite.Run(t, new(KeeperTestSuite))
+}
+
+func (suite *KeeperTestSuite) SetupTest() {
+	suite.T().Log("setting up keeper test suite")
+	merge := func(cdc codec.Codec, state map[string]json.RawMessage) {
+		genesis := &types.GenesisState{
+			Params: &types.Params{
+				AllowList: []string{
+					testAccounts[0].String(),
+				},
+			},
+		}
+		state[types.ModuleName] = cdc.MustMarshalJSON(genesis)
+	}
+
+	lorenzoApp := app.SetupWithGenesisMergeFn(suite.T(), merge)
+	suite.ctx = lorenzoApp.BaseApp.NewContext(false, tmproto.Header{})
+	suite.keeper = lorenzoApp.CCEVkeeper
+
+	queryHelper := baseapp.NewQueryServerTestHelper(suite.ctx, lorenzoApp.InterfaceRegistry())
+	types.RegisterQueryServer(queryHelper, keeper.NewQuerier(suite.keeper))
+	// types.RegisterMsgServer(queryHelper, keeper.NewMsgServerImpl(suite.keeper))
+
+	queryClient := types.NewQueryClient(queryHelper)
+	suite.msgServer = keeper.NewMsgServerImpl(suite.keeper)
+	suite.queryClient = queryClient
+}
+
+func (suite *KeeperTestSuite) CreateClient(chainID uint32, chainName string, initialBlock types.TinyHeader) {
+	err := suite.keeper.CreateClient(suite.ctx, &types.Client{
+		ChainId:      chainID,
+		ChainName:    chainName,
+		InitialBlock: initialBlock,
+	})
+	suite.Require().NoError(err)
+}

x/ccev/keeper/msg_server.go

@@ -70,11 +70,13 @@ func (m msgServer) UpdateParams(goCtx context.Context, msg *types.MsgUpdateParam
 // UploadContract implements types.MsgServer.
 func (m msgServer) UploadContract(goCtx context.Context, msg *types.MsgUploadContract) (*types.MsgUploadContractResponse, error) {
 	ctx := sdk.UnwrapSDKContext(goCtx)
-	if !m.Allow(ctx, msg.Address) {
+	if !m.Allow(ctx, msg.Sender) {
 		return nil, errorsmod.Wrapf(types.ErrUnauthorized, "address %s is not in allowlist", msg.Address)
 	}
 
-	m.Keeper.UploadContract(ctx, msg.ChainId, msg.Address, msg.EventName, msg.Abi)
+	if err := m.Keeper.UploadContract(ctx, msg.ChainId, msg.Address, msg.EventName, msg.Abi); err != nil {
+		return nil, err
+	}
 	return &types.MsgUploadContractResponse{}, nil
 }