Merge upstream #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* RIP: @segment/actions-internal-cli * remove @segmentio/build-experience-team from CODEOWNERS * remove init hook
* Removes delete action, add action. Introduces single sync action * Introduces shared adAccountId top-level setting and audienceSetting * WIP - first draft of a FacebookClient class, including an untested createAudience hook for retl * Adds required customer_file_source field * Adds a dynamic audience field, pulls down all customaudiences as choices * WIP on a pagination mechanism for dynamic fields * Fixes build * Can pass dynamicFieldContext & paging into local server request * Sets paging return such that the previous page was the current page * Removes pagination related code - that work will be saved for later :) * Pulls down 200 most recent audiences in dynamic field response * Removes description param from creating an audience per PRD * WIP - verifying selected audience exists and saving it's ID as output * Checks for existence of user selected audience. Saves audience name and ID when returning from hook * WIP on an inexplicably not passing unit test * Generates types * Splits off engage and retl AdAccountId settings, fun fact: these cannot share a slug * Adding support for FieldDisplayModes & disabling certain input methods (#2187) * update types * added a note on default displayMode * aws s3 bug fixes (#2200) * Fixes unit tests * Introduces a selector for users to choose whether they want to create a new rule or select an existing one * Generates types * Updates hook logic to consider the operation the user selected, if create is selected we will attempt to create even if an existing audience ID exists on the mapping * Removes stray change to aws destination * [Facebook Custom Audiences] Sync users to an audience (#2233) * WIP on syncing users - request likely failing due to bad permissions * Updates usage of adAccountId setting to retlAdAccountId. Fixes type error * Fixes URL when syncing audience. Removes console.logs * Style updates and console.log removals * Implements delete operation * A broken unit test, which I will fix with the next commit * Major implementation of data & schema generation algorithm. The schema is hardcoded to always have the same order, irrespective to whether the payloads contain any of the keys in the hardcoded schema, this is to avoid having to generate a schema based on the present keys across all payloads. This is the method the classic ADS version of this destination takes as well. To generate the 2d data array all payloads are iterated thru, and each present value is inserted into the correct index of a row array which has the same length as the pre-defined schemas array. Each of these row arrays is sequentially appended to the data array. Includes 1 unit test, untested * Updates generateData to be a shared function so it can be exported and unit tested directly. Fixes minor issues and the first unit test is passing * Adds a unit test for multiple payloads. Generates types * Adds batching configuration with max batch size of 10,000. Throws an error if sync mode is not included and the destination does no operation * Updates data generation so batching fields don't trigger an error and are instead ignored. Updates unit tests, generates types * Fixes the referencing of hookOutput fields * Removes a try catch that was discarding errors * Updates sync action unit test * Adds Data normalization to the destination. Includes new unit tests * Updates a unit test with normalization * Removes address object field in favor of individual fields for each item (city, state, etc) * Simplifies normalization functions * Removes unused currency code constants * Removes add and update sync modes. This destination will only support upsert and delete for now --------- Co-authored-by: Pooya Jaferian <[email protected]> Co-authored-by: Joe Ayoub <[email protected]>
* Remove id_type from createAudience call * Remove audience setting
* New Action + properties * Create and get audience functions * perform methods * Add dev token to requests * Better error handling * Add other contact fields * Fix addressInfo * Add smartHash function * Move app_id to audience setting * Add retlOnMappingSave hook * Fixes * Patch browser build fail * add dynamic field * Fixes * Add syncMode * Fix * Refresh token before audience calls * Fix hook output * Fixes * Add unit test * Mess with hook * Add comment about e164
* Add simplified mappings "UploadCallConversion" action * change default value * Add new non-retryable error code for unsupported sync modes * Update Unit Tests * Change language --------- Co-authored-by: Nick Aguilar <[email protected]>
* Add simplified mappings "UploadClickConversion" action * Add non-retry error code * Add unit tests * Change language --------- Co-authored-by: Nick Aguilar <[email protected]>
* Add simplified mappings "UploadConversionAdjustment" action * Add non-retry error code * Add unit tests * Change language --------- Co-authored-by: Nick Aguilar <[email protected]>
* register webhook extensible * change slug * change slug * remove typo
* REGION: add support for vwo data region * REGION: add support for vwo data region * Removed the required field and added the necessary handling. * Fix test case * Make region field Optional --------- Co-authored-by: rohit tyagi <[email protected]>
…nce to handle 401 (#2136) * resolved conflicts * Worked on reauthentication flow for createAudience and getAudience * Removed token refresh and Stats from amazon-amc * Removed commented and unnecessary code * Fixed AudienceDestinationDefinition * Made runFailedAttempt as reusable function across all execute blocks * Added a unit test case for reauthentication flow for createAudience and getAudience * added comment * PR review comments:- Added unit test case for non-oauth scheme and non 401 * Split failedAttemptHandler into three seperate methods --------- Co-authored-by: Gaurav Kochar <[email protected]> Co-authored-by: Joe Ayoub <[email protected]>
…hod (#2232) * restricting additional_identifiers_and_traits_columns field entry methods * Update packages/destination-actions/src/destinations/aws-s3/syncAudienceToCSV/index.ts Co-authored-by: Pooya Jaferian <[email protected]> --------- Co-authored-by: Pooya Jaferian <[email protected]>
* adding properties dynamic field * getting started on sensitive props * saving progress sensitive props * senstivie props working * supporting arrays and object properties * force lowercase for property names * scaffolw custom event * scaffolw custom event * scaffolw custom event * removing token * removing customEvent * removing customEvent
* removing setting for datacenter * sendNormalizeIdType = false
* ExternalID is now required * Moves country towards the top of the list of fields and gender down the list * Updates descriptions for each field to be prod ready * Generates types * Adds smart hashing from actions-core and removees manual hashing implementation * Removes unused refreshAccessToken method * WIP - smart Hashing implementation * Smart Hashing unit tests passing * Adds unit tests to ensure mobileAdId and app_ids are not hashed * Appends an app_ids and page_ids array to the downstream payload only if there are non-empty items in the arrays. Updates unit tests * Adds hashing-utils unit tests
* adding customEvent action * moving folder to correct lotion * moving folder * update * saving progress * saving progress * saving progress - not using batch any more * saving progress again * more progress * custom event - post video share * email default path change * renaming Upsert Object Action * testing and adding property validation * changing sort function * refacting * saving progress * fixing up the dynamic dropdowns * ready to deploy * correcting auth token
* Initial destination scaffold + auth check * Added trackAi action to destination * Call track instead and add user_id param * Added Identify User action to destination * Renamed the destination to Dawn and added description about write key * Added tests for destination and 2 methods * pr review fixes * enable batching * add context mapping * fixes + simplify --------- Co-authored-by: alexisgauba <[email protected]>
* Add phone number as identifier in add profile to list and remove profile from list * add phone number for remove profile action * Update snapshot * Update tests * Fix test descriptions * Add E.164 validation in all actions, update test cases, update snapshots * Revert non engage actions changes to original state (splitting large PR) * Add removeProfile actions changes * Update snapshots
* Enable codecov * noop * Run all tests * Run all tests * Update codecov config * move codecov.yml to root * Disable github checks for now We shall monitor codecov reports for a week and then move to intermediary configuration
* WIP - successfully tested locally * Removes console.log * Adds enable_batching and batch_size fields, defaults to batching of max size 5000. Updates unit tests
* Removes required: true property for batch fields - we can't add new required fields * Generates types
Co-authored-by: Maryam Sharif <[email protected]>
* add type checking to statusCode * isolate response status code
* fixing test * implementing changes * fix test * create test, clean code * Fix code and TC * updating snapshots --------- Co-authored-by: Joe Ayoub <[email protected]>
* bug fix * Adding more unit tests. --------- Co-authored-by: Leonel Sanches <[email protected]>
* Verify customerId exists * Hide event name * Make descriptions clearer * Update field descriptions * Generate types
…#2300) * [STRATCONN-4058] handle salesforce concurrent refresh error * [Salesforce Actions] Try another approach * Add comments * updates new refresh token description
…rver to delivr ai REST API (#2158) * added delivrai activate * added action destination delivr activate * Added delivrai-activate action destination * Added delivrai-activate action destination * Added delivr AI actiavte Audienc segment * Added delivr AI actiavte Audienc segment * added addition fields * added addition fields * removed unused commented code * removed unused commented code * removed unused commented code * Un commented success test case * Fixed server ts * Fixed server ts * code cleanup and improvments * Revert package.json to match main branch * apply formatting and consistent punctuation * Updated types * added fix for type * added device_type field --------- Co-authored-by: unknown <[email protected]> Co-authored-by: Thomas Gilbert <[email protected]>
* - Fixing TikTok Conversions payload regarding `test_event_code`; - Better typing; - Not setting fields when they are not set in the mapping. * Updating TikTok Conversions unit tests. * More updates in TikTok Conversions unit tests. * In Tiktok Conversions, field is optional under object.
* bug fixes for hubspot new actions * bug fix for Hubspot
* Remove hyphens from customer id in create/get Audience calls * getAudience to return if segment in db * Address comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A summary of your pull request, including the what change you're making and why.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.