Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidepool merge browser build update #214

Merged

Conversation

marionbarker
Copy link
Contributor

Purpose:

The purpose of this PR is to:

  • enable browser build of tidepool-merge branch (requires Xcode 16, selected 16.1)
  • match the browser build sync and keep alive methods found in Loop 3.4.4
  • do not print out table of personal information in the GitHub action logs
  • update to Fastlane 2.223.1

Dependency

This requires the Loop PR 2241 be applied to the tidepool-merge branch of Loop and that new SHA for Loop be added to the LoopWorkspace. (The current Loop PR 2241 points to the dev branch of Loop.)

Testing

Browser Build testing

It was tested by adding a customization to the build_loop.yml file on the loopdocs-tester GitHub account:

# This patch fixes the expiration date for Xcode 16 and later
curl https://github.com/loopandlearn/Loop/commit/ae76f90955843df0e1e4297f6c7c669d21e5eae2.patch | git apply --directory=Loop -v --whitespace=fix

The successful build link is here

Installed from TestFlight onto an iOS 15.8.3 phone and an iOS 18.1 phone.
Both installations now display the TestFlight Expiration under Loop, Settings.

Mac-Xcode testing

This branch (with the modified Loop code) was built successfully onto an iOS 18.1 test phone using Xcode 16.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants