-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chg: hide top-up button on dashboard's footer dependng on the ``topUp… #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeddikKadi
force-pushed
the
hide-topup
branch
from
September 2, 2024 07:06
5a8dce8
to
f62f67d
Compare
✔️ translation is up-to-date✔️ code style matches our guidelines📃 Metrics reportBundle size analysis
-129094 js/50.8446c537.js
+129094 js/50.25e59abd.js
-175702 js/app.1fe40d26.js
-1983281 js/chunk-vendors.984b1953.js
-242886 css/app.64ca62ec.css
+175770 js/app.70969ad1.js
+1983281 js/chunk-vendors.7a89b231.js
+242886 css/app.b3f236df.css Eslint analysis
-/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:386:13: 'dateBegin' is never reassigned. Use 'const' instead. [Error/prefer-const]
-/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:386:13: 'dateBegin' is assigned a value but never used. [Error/@typescript-eslint/no-unused-vars]
-/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:394:23: Unexpected any. Specify a different type. [Error/@typescript-eslint/no-explicit-any]
-/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:445:11: Unexpected console statement. [Warning/no-console]
-/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:473:34: Unexpected any. Specify a different type. [Error/@typescript-eslint/no-explicit-any]
-/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:493:38: 'reject' is defined but never used. [Error/@typescript-eslint/no-unused-vars]
+/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:391:13: 'dateBegin' is never reassigned. Use 'const' instead. [Error/prefer-const]
+/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:391:13: 'dateBegin' is assigned a value but never used. [Error/@typescript-eslint/no-unused-vars]
+/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:399:23: Unexpected any. Specify a different type. [Error/@typescript-eslint/no-explicit-any]
+/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:450:11: Unexpected console statement. [Warning/no-console]
+/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:478:34: Unexpected any. Specify a different type. [Error/@typescript-eslint/no-explicit-any]
+/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:498:38: 'reject' is defined but never used. [Error/@typescript-eslint/no-unused-vars] |
🌲 test reportPasses: 4, failures: 14, pending: 0, skipped: 2, other: 0.
|
SeddikKadi
force-pushed
the
hide-topup
branch
from
September 11, 2024 14:39
f62f67d
to
7857c05
Compare
…`` variable in config.json
SeddikKadi
force-pushed
the
hide-topup
branch
from
September 11, 2024 14:43
7857c05
to
6198098
Compare
vaab
force-pushed
the
main
branch
2 times, most recently
from
September 11, 2024 15:51
634e686
to
a238eca
Compare
Live reviewed, a few small adjustement, pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…`` variable in config.json