Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chg: hide top-up button on dashboard's footer dependng on the ``topUp… #402

Closed
wants to merge 4 commits into from

Conversation

SeddikKadi
Copy link
Collaborator

…`` variable in config.json

Copy link

github-actions bot commented Sep 2, 2024

✔️ translation is up-to-date

✔️ code style matches our guidelines

📃 Metrics report

Bundle size analysis

-129094	js/50.8446c537.js
+129094	js/50.25e59abd.js
-175702	js/app.1fe40d26.js
-1983281	js/chunk-vendors.984b1953.js
-242886	css/app.64ca62ec.css
+175770	js/app.70969ad1.js
+1983281	js/chunk-vendors.7a89b231.js
+242886	css/app.b3f236df.css

Eslint analysis

-/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:386:13: 'dateBegin' is never reassigned. Use 'const' instead. [Error/prefer-const]
-/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:386:13: 'dateBegin' is assigned a value but never used. [Error/@typescript-eslint/no-unused-vars]
-/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:394:23: Unexpected any. Specify a different type. [Error/@typescript-eslint/no-explicit-any]
-/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:445:11: Unexpected console statement. [Warning/no-console]
-/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:473:34: Unexpected any. Specify a different type. [Error/@typescript-eslint/no-explicit-any]
-/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:493:38: 'reject' is defined but never used. [Error/@typescript-eslint/no-unused-vars]
+/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:391:13: 'dateBegin' is never reassigned. Use 'const' instead. [Error/prefer-const]
+/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:391:13: 'dateBegin' is assigned a value but never used. [Error/@typescript-eslint/no-unused-vars]
+/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:399:23: Unexpected any. Specify a different type. [Error/@typescript-eslint/no-explicit-any]
+/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:450:11: Unexpected console statement. [Warning/no-console]
+/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:478:34: Unexpected any. Specify a different type. [Error/@typescript-eslint/no-explicit-any]
+/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:498:38: 'reject' is defined but never used. [Error/@typescript-eslint/no-unused-vars]

Copy link

github-actions bot commented Sep 2, 2024

🌲 test report

Passes: 4, failures: 14, pending: 0, skipped: 2, other: 0.
State Description
fail Filepath: tests/e2e/spec.cy.ts
Title: Login and logout process start page show base interface and login form
Error: AssertionError: Timed out retrying after 60000ms: Expected to find element: button, but never found it. Queried from: > cy.get(.links-container)
fail Filepath: tests/e2e/spec.cy.ts
Title: Login and logout process login with correct credentials succeeds, logout
Error: AssertionError: Timed out retrying after 60000ms: Expected to find element: .action-footer:visible, but never found it.
fail Filepath: tests/e2e/spec.cy.ts
Title: General processes when logged in show base interface
Error: AssertionError: Timed out retrying after 60000ms: Expected to find element: .accounts, but never found it.
fail Filepath: tests/e2e/spec.cy.ts
Title: General processes when logged in Send money process
Error: AssertionError: Timed out retrying after 60000ms: Expected to find element: .accounts, but never found it.
fail Filepath: tests/e2e/spec.cy.ts
Title: General processes when logged in Top-up process
Error: AssertionError: Timed out retrying after 60000ms: Expected to find element: .accounts, but never found it.
fail Filepath: tests/e2e/spec.cy.ts
Title: Preferences page show base interface
Error: AssertionError: Timed out retrying after 60000ms: Expected to find element: .action-footer:visible, but never found it.
fail Filepath: tests/e2e/spec.cy.ts
Title: Signup process Signup page show form
Error: AssertionError: Timed out retrying after 60000ms: Expected to find element: button, but never found it. Queried from: > cy.get(.links-container) Because this error occurred during a before each hook we are skipping the remaining tests in the current suite: Signup process
skipped Filepath: tests/e2e/spec.cy.ts
Title: Signup process Signup with already existing email
Error: null
fail Filepath: tests/e2e/spec.cy.ts
Title: Login and logout process start page show base interface and login form
Error: AssertionError: Timed out retrying after 60000ms: Expected to find element: button, but never found it. Queried from: > cy.get(.links-container)
fail Filepath: tests/e2e/spec.cy.ts
Title: Login and logout process login with correct credentials succeeds, logout
Error: AssertionError: Timed out retrying after 60000ms: Expected to find element: .action-footer:visible, but never found it.
fail Filepath: tests/e2e/spec.cy.ts
Title: General processes when logged in show base interface
Error: AssertionError: Timed out retrying after 60000ms: Expected to find element: .accounts, but never found it.
fail Filepath: tests/e2e/spec.cy.ts
Title: General processes when logged in Send money process
Error: AssertionError: Timed out retrying after 60000ms: Expected to find element: .accounts, but never found it.
fail Filepath: tests/e2e/spec.cy.ts
Title: General processes when logged in Top-up process
Error: AssertionError: Timed out retrying after 60000ms: Expected to find element: .accounts, but never found it.
fail Filepath: tests/e2e/spec.cy.ts
Title: Preferences page show base interface
Error: AssertionError: Timed out retrying after 60000ms: Expected to find element: .action-footer:visible, but never found it.
fail Filepath: tests/e2e/spec.cy.ts
Title: Signup process Signup page show form
Error: AssertionError: Timed out retrying after 60000ms: Expected to find element: button, but never found it. Queried from: > cy.get(.links-container) Because this error occurred during a before each hook we are skipping the remaining tests in the current suite: Signup process
skipped Filepath: tests/e2e/spec.cy.ts
Title: Signup process Signup with already existing email
Error: null

@vaab
Copy link
Collaborator

vaab commented Sep 11, 2024

Live reviewed, a few small adjustement, pushed

@vaab vaab closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants