[FIX] lcc_lokavaluto_app_connection: correction on sale_order creati

on order management from credit_requests
Lokavaluto · May 23, 2024 · e3c2648 · e3c2648
1 parent 7dd5723
commit e3c2648
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 9 deletions.
diff --git a/lcc_comchain_base/migrations/12.0.3.0.0/post-migrate.py b/lcc_comchain_base/migrations/12.0.3.0.0/post-migrate.py
@@ -44,7 +44,7 @@ def migrate(env, version):
                 "partner_id": partner_id.id,
                 "wallet_id": wallet.id,
                 "invoice_id": invoice[0],
-                "create_order": False,
+                "no_order": True,
             }
         )
         env["credit.request"].create(values)

diff --git a/lcc_credit_requests_from_contracts/models/contract.py b/lcc_credit_requests_from_contracts/models/contract.py
@@ -13,7 +13,7 @@ def _prepare_credit_request_values(self, invoice):
             "partner_id": invoice.partner_id.id,
             "wallet_id": self.wallet_id.id,
             "invoice_id": invoice.id,
-            "create_order": False,
+            "no_order": True,
         }
         return values
 

diff --git a/lcc_cyclos_base/migrations/12.0.3.0.0/post-migrate.py b/lcc_cyclos_base/migrations/12.0.3.0.0/post-migrate.py
@@ -33,7 +33,7 @@ def migrate(env, version):
             "partner_id": partner_id.id,
             "wallet_id": wallet.id,
             "invoice_id": invoice[0],
-            "create_order": False,
+            "no_order": True,
         }
         env["credit.request"].create(values)
 

diff --git a/lcc_lokavaluto_app_connection/models/credit_request.py b/lcc_lokavaluto_app_connection/models/credit_request.py
@@ -36,12 +36,15 @@ def create(self, vals):
             raise UserError("Credit resquest can't be created with a null amount.")
 
         res = super(CreditRequest, self).create(vals)
+
+        if vals.get("no_order", False):
+            return res
+
         # Create Sale Order to get credit request payment
-        if vals.get("create_order", False):
-            new_order = res.partner_id.create_numeric_lcc_order(
-                res.wallet_id, res.amount
-            )
-            res.order_id = new_order.id
+        new_order = res.partner_id.create_numeric_lcc_order(
+            res.wallet_id, res.amount
+        )
+        res.order_id = new_order.id
         return res
 
     @api.multi

diff --git a/lcc_lokavaluto_app_connection/wizards/create_credit_request.py b/lcc_lokavaluto_app_connection/wizards/create_credit_request.py
@@ -22,7 +22,6 @@ def create_credit_request(self):
         values = {
             "wallet_id": self.wallet_id.id,
             "amount": self.amount,
-            "create_order": True,
         }
         credit_request_id = self.env["credit.request"].create(values)
         view = self.env.ref("lcc_lokavaluto_app_connection.credit_request_view_form")