Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

feat: S3 Deployment Workflow #33

Merged
merged 5 commits into from
Nov 25, 2023
Merged

feat: S3 Deployment Workflow #33

merged 5 commits into from
Nov 25, 2023

Conversation

vincentkoc
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

Terraform Plan 📖success

Show Plan 

terraform

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Comment with apply to run Terraform apply
Pusher: @koconder, Action: pull_request, Workflow: Terraform

larriquin
larriquin approved these changes Nov 25, 2023
View reviewed changes
Copy link
Contributor

@larriquin larriquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think I should be able to replace the AWS creds with OIDC too eventually!

@vincentkoc vincentkoc merged commit 7135386 into main Nov 25, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@larriquin larriquin larriquin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentkoc @larriquin