Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "nixpkgs: make config.nixpkgs.{buildPlatform,hostPlatform} write only" #1322

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

emilazy
Copy link
Collaborator

@emilazy emilazy commented Feb 5, 2025

This was reverted upstream in 0b47fba23078cc01251b136c7af0127abd57112b.

This reverts commit 7c72c01.


Keeping the module in sync with NixOS. This should only be merged once https://nixpk.gs/pr-tracker.html?pr=379615 is green on all channels, since otherwise it’ll break people’s systems again.

@emilazy emilazy requested a review from Enzime February 5, 2025 15:10
Enzime
Enzime previously approved these changes Feb 5, 2025
Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…te only"

This was reverted upstream in 0b47fba23078cc01251b136c7af0127abd57112b.

This reverts commit 7c72c01.
@emilazy
Copy link
Collaborator Author

emilazy commented Feb 8, 2025

Pushed to fix an embarrassing copy‐paste mishap in the earlier backport commits that got mangled by nixfmt + deprecated URL literals. The upstream revert has landed on all channels now, so the tests should pass.

@emilazy emilazy merged commit 0b6f96a into LnL7:master Feb 8, 2025
3 checks passed
@emilazy emilazy deleted the push-trvmqywuwnop branch February 8, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants